Closed Bug 1480869 Opened 2 years ago Closed 2 years ago
Stop using SRTP cipher suites from NSS
46 bytes, text/x-phabricator-request
|Details | Review|
To be able to use GCM cipher suites in SRTP in Firefox we need to add SRTP_AEAD_AES_128_GCM and SRTP_AEAD_AES_256_GCM to NSS.
Comment on attachment 8997553 [details] Summary: add SRTP GCM cipher values to NSS Eric Rescorla (:ekr) has approved the revision.
Attachment #8997553 - Flags: review+
Martin: how do I make a try run on this? Just run Firefox mochitest which involve SRTP, or apply the change to a fresh NSS checkout?
You will need to run try on both NSS and gecko. I mean, the change is so trivial you might be able to skimp on some testing, but both sets of tests will ultimately need to pass.
https://hg.mozilla.org/projects/nss-try/rev/87491ee6e77e3e1d1e36079eba471057446bdf19 Bug 1480869: add SRTP GCM cipher values to NSS
Both try runs seem to have passed. But as a novice mistake the patch in Phabricator is against mozilla-central, not for the NSS repository. Can we land this in mozilla-central and later integrate into NSS, or do I need to provide a new patch against NSS?
It needs to land into NSS, as I'll otherwise clobber it shortly thereafter when I uplift NSS into m-c.
Nils, would you prefer to take and modify https://phabricator.services.mozilla.com/D4188 instead? That seems to be ready.
Component: Libraries → WebRTC: Networking
Product: NSS → Core
Summary: Add SRTP_AEAD_AES GCM cipher suites → Stop using SRTP cipher suites from NSS
Version: trunk → unspecified
define SRTP cipher suites inside mtransport
Comment on attachment 9007949 [details] Bug 1480869: define SRTP ciphers suites inside mtransport Martin Thomson [:mt:] has approved the revision.
Attachment #9007949 - Flags: review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/cf2e01678e1f define SRTP ciphers suites inside mtransport r=mt
You need to log in before you can comment on or make changes to this bug.