Closed Bug 1480869 Opened 2 years ago Closed 2 years ago

Stop using SRTP cipher suites from NSS


(Core :: WebRTC: Networking, enhancement, P2)




Tracking Status
firefox64 --- fixed


(Reporter: drno, Assigned: drno)




(1 file, 1 obsolete file)

To be able to use GCM cipher suites in SRTP in Firefox we need to add SRTP_AEAD_AES_128_GCM and SRTP_AEAD_AES_256_GCM to NSS.
Assignee: nobody → drno
Comment on attachment 8997553 [details]
Summary: add SRTP GCM cipher values to NSS

Eric Rescorla (:ekr) has approved the revision.
Attachment #8997553 - Flags: review+
Martin: how do I make a try run on this? Just run Firefox mochitest which involve SRTP, or apply the change to a fresh NSS checkout?
Flags: needinfo?(martin.thomson)
You will need to run try on both NSS and gecko. I mean, the change is so trivial you might be able to skimp on some testing, but both sets of tests will ultimately need to pass.
Flags: needinfo?(martin.thomson)
Both try runs seem to have passed.

But as a novice mistake the patch in Phabricator is against mozilla-central, not for the NSS repository. Can we land this in mozilla-central and later integrate into NSS, or do I need to provide a new patch against NSS?
Flags: needinfo?(martin.thomson)
It needs to land into NSS, as I'll otherwise clobber it shortly thereafter when I uplift NSS into m-c.
Flags: needinfo?(martin.thomson)
Nils, would you prefer to take and modify instead?  That seems to be ready.
Ok, lets land bug 1485883 and then I can follow up here.
Depends on: 1485883
Component: Libraries → WebRTC: Networking
Product: NSS → Core
Summary: Add SRTP_AEAD_AES GCM cipher suites → Stop using SRTP cipher suites from NSS
Version: trunk → unspecified
Rank: 15
Priority: -- → P2
define SRTP cipher suites inside mtransport
Attachment #8997553 - Attachment is obsolete: true
Comment on attachment 9007949 [details]
Bug 1480869: define SRTP ciphers suites inside mtransport

Martin Thomson [:mt:] has approved the revision.
Attachment #9007949 - Flags: review+
Keywords: checkin-needed
Keywords: checkin-needed
Pushed by
define SRTP ciphers suites inside mtransport r=mt
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.