1480915 - add aarch64 windows support to breakpad

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, enhancement)

Description

[Nathan Froyd [:froydnj]]

Ted noticed that Google is adding (or revising) such support:

https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1155938

We should try to ensure crash reporting works with the new port.

Comment 1

[Nathan Froyd [:froydnj]]

Bug 1440282 updated breakpad and brought in some basic AArch64 support in the minidump processor.

Comment 2

[(not currently active) Ted Mielczarek]

We'll have to separately update the snapshot of Breakpad used in Socorro if we want to test submitting Windows aarch64 crashes to crash-stats.

Comment 3

[Eric Rahm [:erahm]]

(In reply to Nathan Froyd [:froydnj] from comment #1)
> Bug 1440282 updated breakpad and brought in some basic AArch64 support in
> the minidump processor.

So is this done? Can we --enable-crashreporter? If not what's left to do?

(In reply to Ted Mielczarek [:ted] [:ted.mielczarek] from comment #2)
> We'll have to separately update the snapshot of Breakpad used in Socorro if
> we want to test submitting Windows aarch64 crashes to crash-stats.

I guess we should add a separate bug for this. Is it just updating the build, or do we need to change how we annotate on the client side and process on the server side?

Comment 4

[Nathan Froyd [:froydnj]]

(In reply to Eric Rahm [:erahm] from comment #3)
> (In reply to Nathan Froyd [:froydnj] from comment #1)
> > Bug 1440282 updated breakpad and brought in some basic AArch64 support in
> > the minidump processor.
> 
> So is this done? Can we --enable-crashreporter? If not what's left to do?

AArch64 Windows builds already run with --enable-crashreporter...at least I have not been using --disable-crashreporter in my mozconfigs.

Gabriele is working on building dump_syms correctly in bug 1497583, which we'd need to start testing symbol dumping.

I guess we'd see if this is working correctly by...running the crashreporter tests locally, or something like that?  Gabriele?

> (In reply to Ted Mielczarek [:ted] [:ted.mielczarek] from comment #2)
> > We'll have to separately update the snapshot of Breakpad used in Socorro if
> > we want to test submitting Windows aarch64 crashes to crash-stats.
> 
> I guess we should add a separate bug for this. Is it just updating the
> build, or do we need to change how we annotate on the client side and
> process on the server side?

302 ted for knowing more than me about this part.

Comment 5

[(not currently active) Ted Mielczarek]

Updating Socorro's snapshot looks like bug 1421988. It's not a large amount of work, we just need to make sure that the stackwalker that runs in crash-stats production is running the latest Breakpad code so it can read these dumps.

Symbol dumping for aarch64 might additionally need some work comparable to the unwind info dumping I did for x86-64 (originally in bug 548035, integrated into Breakpad upstream in https://chromium.googlesource.com/breakpad/breakpad/+/213a0698cbfe226f4a3dcaec31cdcab54ec9ca5a%5E%21/ )

Comment 6

[Gabriele Svelto [:gsvelto]]

I haven't started working on bug 1497583 unfortunately, I tried setting up an AArch64 cross-build on Windows but didn't go very far. In addition to the changes required for symbol dumping support for AArch64 in Breakpad is still very limited and it doesn't look like anybody else is in a rush to getting it up to speed.

Comment 7

[Gabriele Svelto [:gsvelto]]

This was fixed in the oxidized version of dump_syms a while ago, I forgot to close this bug