Closed Bug 1480961 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 12308 - Fix typo in Media Capabilities IDL test

Categories

(Core :: Audio/Video: Playback, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 12308 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12308
Details from upstream follow.

Philip Jägenstedt <philip@foolip.org> wrote:
>  Fix typo in Media Capabilities IDL test
>  
>  Fixes https://github.com/web-platform-tests/wpt/issues/12306
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → WebRTC: Audio/Video
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 2 tests and 116 subtests
OK     : 2
PASS   : 18
FAIL   : 98

New tests that have failures or other problems:
/media-capabilities/idlharness.any.html
    MediaCapabilities interface: calling decodingInfo(MediaDecodingConfiguration) on navigator.mediaCapabilities with too few arguments must throw TypeError: FAIL
    MediaCapabilities interface: calling encodingInfo(MediaEncodingConfiguration) on navigator.mediaCapabilities with too few arguments must throw TypeError: FAIL
    MediaCapabilities interface: navigator.mediaCapabilities must inherit property "decodingInfo(MediaDecodingConfiguration)" with the proper type: FAIL
    MediaCapabilities interface: navigator.mediaCapabilities must inherit property "encodingInfo(MediaEncodingConfiguration)" with the proper type: FAIL
    MediaCapabilities must be primary interface of navigator.mediaCapabilities: FAIL
    Stringification of navigator.mediaCapabilities: FAIL
/media-capabilities/idlharness.any.worker.html
    MediaCapabilities interface: calling decodingInfo(MediaDecodingConfiguration) on navigator.mediaCapabilities with too few arguments must throw TypeError: FAIL
    MediaCapabilities interface: calling encodingInfo(MediaEncodingConfiguration) on navigator.mediaCapabilities with too few arguments must throw TypeError: FAIL
    MediaCapabilities interface: navigator.mediaCapabilities must inherit property "decodingInfo(MediaDecodingConfiguration)" with the proper type: FAIL
    MediaCapabilities interface: navigator.mediaCapabilities must inherit property "encodingInfo(MediaEncodingConfiguration)" with the proper type: FAIL
    MediaCapabilities must be primary interface of navigator.mediaCapabilities: FAIL
    Stringification of navigator.mediaCapabilities: FAIL
I get only 4 errors with current nightly... 

Looking at the .ini meta

it's missing:
prefs: [media.media-capabilities.enabled:true]

at the top, e.g.

[idlharness.any.html]
  prefs: [media.media-capabilities.enabled:true]
Component: WebRTC: Audio/Video → Audio/Video: Playback
Flags: needinfo?(james)
OK, if you submit that change as a patch I'm happy to review :) If the pref should be set for all files in that directory you should be able to add a __dir_.ini file in the directory with the prefs setting at the top level.
Flags: needinfo?(james)
See Also: → 1481176
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/967a27d153e8
[wpt PR 12308] - Fix typo in Media Capabilities IDL test, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/2088bbf35507
[wpt PR 12308] - Update wpt metadata, a=testonly
The ini file still contains reference to tests that no longer exist (as they were based on the bug's typo)

shouldn't those be removed?
Flags: needinfo?(james)
Yes, but we aren't good at automatically cleaning out vestigial subtests (for kind of reasonable reasons, but I should probably add an option to do that during the sync). In the meantime they don't really do anything harmful.
Flags: needinfo?(james)
https://hg.mozilla.org/mozilla-central/rev/967a27d153e8
https://hg.mozilla.org/mozilla-central/rev/2088bbf35507
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.