Closed Bug 1480971 Opened 6 years ago Closed 6 years ago

add AccessibleNode::mRelationProperties to NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE

Categories

(Core :: Disability Access APIs, enhancement)

Product:
Core
Component:
Disability Access APIs
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: dora.tokio, Assigned: dora.tokio)

Details

Attachments

(1 file)

patch
3.31 KB, patch
surkov
: review+
Details | Diff | Splinter Review 
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.99 Safari/537.36




Expected results:

AccessibleNode::mRelationProperties have strong references to AccessibleNodes, so this property should be included in NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE macro.
Attached patch patch — — Splinter Review 

        Attachment #8997644 -
        Flags: review?(surkov.alexander)

        Attachment #8997644 -
        Flags: review?(surkov.alexander) → review+
Assignee: nobody → dora.tokio
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: checkin-needed

    
    

    
  
Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d640ff079867
add AccessibleNode::mRelationProperties to NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE r=surkov
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/d640ff079867
Status: NEW → RESOLVED
Closed: 6 years ago

          status-firefox63:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: