1480975 - If deleting or cutting an occurrence of a recurring event being an invitation one should be able to specify whether to notify participants already in the occurrenec prompt

Status: NEW

(Calendar :: E-mail based Scheduling (iTIP/iMIP), enhancement)

Description

[[:MakeMyDay]]

Follow-up to bug 1479449, which already removed the additional occurence prompt for the deletion operarion when cutting.

On top of that, we should offer allow to specify already within the occurrence prompt whether to notify participants about deletion of the event (either because the user deletes explicitely or cuts) like we already do in the clandar chooser when pasting and avoid the subsequent notification prompt.

Further unifying the decision when cutting and pasting is currently technically not possible and therefore not in scope of this bug.

Comment 1

[[:MakeMyDay]]

Attachment: AvoidAdditionalPromptToSendNotificationsIfDeletingOrCuttingItemsFromViews-V1.diff

This patch takes care.It introduces menu buttons in the occurrence prompt for cut and delete operation if an invitation is detected in the selected items.

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8999179 [details] [diff] [review]
AvoidAdditionalPromptToSendNotificationsIfDeletingOrCuttingItemsFromViews-V1.diff

Review of attachment 8999179 [details] [diff] [review]:
-----------------------------------------------------------------

r+wc

::: calendar/base/content/calendar-item-editing.js
@@ +535,5 @@
>   *                                        This parameter can for example be
>   *                                        false if a deletion is being made.
>   * @param aAction                       Either "edit" or "delete". Sets up
>   *                                          the labels in the occurrence prompt
> + * @return [modifiedItem, futureItem, promptResponse, notify]

Might be worth switching this to an object if we are adding more parameters. Also a lot nicer with the new let { modifiedItem, futureItem } = promptOccurrenceModification() syntax.

For jsdoc we can use this: http://usejsdoc.org/tags-param.html#parameters-with-properties

::: calendar/base/content/dialogs/calendar-occurrence-prompt.xul
@@ +91,3 @@
>                `buttons.${multiple}.parent.${action}.label`
> +          ));
> +          

Some whitespace here, can you run eslint?