1481005 - Perma-failing tier2 z:\build\build\src\obj-firefox\dist\include\mozilla/Alignment.h(29): error C2220: warning treated as error - no 'object' file generated

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: apavel [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=192047664&repo=mozilla-central

https://queue.taskcluster.net/v1/task/MqE9oyK3SqKF4x9d3w7Vmw/runs/0/artifacts/public/logs/live_backing.log

12:59:42     INFO -  Unified_cpp_reflect_xptinfo0.cpp
12:59:42     INFO -  mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/xpcom/reflect/xptinfo'
12:59:42     INFO -  mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/js/src'
12:59:42     INFO -  mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/js/src'
12:59:42     INFO -  mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/js/src'
12:59:42     INFO -  mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/js/src'
12:59:43     INFO -  mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/xpcom/reflect/xptcall'
12:59:43     INFO -  z:/build/build/src/obj-firefox/_virtualenvs/init/Scripts/python.exe -m mozbuild.action.cl  z:/build/build/src/vs2017_15.6.6/VC/bin/Hostx64/x64/cl.exe -Foxptcall.obj -c -Iz:/build/build/src/obj-firefox/dist/stl_wrappers -DDEBUG=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -Iz:/build/build/src/xpcom/reflect/xptcall -Iz:/build/build/src/obj-firefox/xpcom/reflect/xptcall -Iz:/build/build/src/obj-firefox/dist/include -Iz:/build/build/src/obj-firefox/dist/include/nspr -Iz:/build/build/src/obj-firefox/dist/include/nss -MD -FI z:/build/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -utf-8 -TP -nologo -w15038 -wd5026 -wd5027 -Zc:sizedDealloc- -wd4091 -wd4577 -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -Gw -wd4251 -wd4244 -wd4267 -wd4800 -wd4595 -wd4065 -we4553 -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Zi -O1 -Oi -Oy- -WX    -Fdgenerated.pdb -FS  z:/build/build/src/xpcom/reflect/xptcall/xptcall.cpp
12:59:43     INFO -  xptcall.cpp
12:59:43     INFO -  z:\build\build\src\obj-firefox\dist\include\mozilla/Alignment.h(29): error C2220: warning treated as error - no 'object' file generated
12:59:43     INFO -  z:\build\build\src\obj-firefox\dist\include\mozilla/Alignment.h(32): note: see reference to class template instantiation 'mozilla::AlignmentFinder<nsXPTCVariant::ExtendedVal>::Aligner' being compiled
12:59:43     INFO -  z:\build\build\src\xpcom\reflect\xptcall\xptcall.h(126): note: see reference to class template instantiation 'mozilla::AlignmentFinder<nsXPTCVariant::ExtendedVal>' being compiled
12:59:43     INFO -  z:\build\build\src\obj-firefox\dist\include\mozilla/Alignment.h(29): warning C4624: 'mozilla::AlignmentFinder<nsXPTCVariant::ExtendedVal>::Aligner': destructor was implicitly defined as deleted
12:59:43     INFO -  z:/build/build/src/config/rules.mk:1086: recipe for target 'xptcall.obj' failed
12:59:43     INFO -  mozmake.EXE[4]: *** [xptcall.obj] Error 2
12:59:43     INFO -  mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/xpcom/reflect/xptcall'
12:59:43     INFO -  z:/build/build/src/config/recurse.mk:74: recipe for target 'xpcom/reflect/xptcall/target' failed
12:59:43     INFO -  mozmake.EXE[3]: *** [xpcom/reflect/xptcall/target] Error 2
12:59:43     INFO -  mozmake.EXE[3]: *** Waiting for unfinished jobs....
12:59:43     INFO -  mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/config/external/icu/common'
12:59:43     INFO -  mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/config/external/icu/common'
12:59:43     INFO -  mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/config/external/icu/common'
12:59:43     INFO -  mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/config/external/icu/common'
12:59:43     INFO -  mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/config/external/icu/i18n'
12:59:43     INFO -  mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/config/external/icu/i18n'
12:59:43     INFO -  mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/config/external/icu/i18n'
12:59:43     INFO -  mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/config/external/icu/i18n'
12:59:43     INFO -  mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/config/external/icu/common'
12:59:43     INFO -  z:/build/build/src/obj-firefox/_virtualenvs/init/Scripts/python.exe -m mozbuild.action.cl  z:/build/build/src/vs2017_15.6.6/VC/bin/Hostx64/x64/cl.exe -Founormcmp.obj -c -DDEBUG=1 -DU_COMMON_IMPLEMENTATION -DUCONFIG_NO_TRANSLITERATION -DUCONFIG_NO_REGULAR_EXPRESSIONS -DUCONFIG_NO_LEGACY_CONVERSION -DU_USING_ICU_NAMESPACE=0 -DU_NO_DEFAULT_INCLUDE_UTF_HEADERS=1 -DU_CHARSET_IS_UTF8 -DU_HAVE_NL_LANGINFO_CODESET=0 -DU_DEBUG=1 -Iz:/build/build/src/config/external/icu/common -Iz:/build/build/src/obj-firefox/config/external/icu/common -Iz:/build/build/src/intl/icu/source/i18n -Iz:/build/build/src/obj-firefox/dist/include -Iz:/build/build/src/obj-firefox/dist/include/nspr -Iz:/build/build/src/obj-firefox/dist/include/nss -MD -FI z:/build/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -utf-8 -TP -nologo -w15038 -wd5026 -wd5027 -Zc:sizedDealloc- -wd4091 -wd4577 -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -Gw -wd4251 -wd4244 -wd4267 -wd4800 -wd4595 -wd4065 -we4553 -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Zi -O1 -Oi -Oy- -GR -wd4005 -wd4333 -wd4996    -Fdgenerated.pdb -FS  z:/build/build/src/intl/icu/source/common/unormcmp.cpp
12:59:43     INFO -  cl : Command line warning D9025 : overriding '/GR-' with '/GR'
12:59:43     INFO -  unormcmp.cpp

Comment 1

[Justin Wood (:Callek)]

Broke on windows msvc builds - Possibly related to Bug 1480624 ?

Comment 2

[Justin Wood (:Callek)]

(I triggered a Bmsvc for win2012 debug on the initial inbound push to verify: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=8376dfb0af8293dfbb1550aed3b614c9c681523b&filter-searchStr=Bmsvc

Comment 3

[Cosmin Sabou [:CosminS]]

Seems like this indeed started after Bug 1480624 landed: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-searchStr=Bmsvc&tochange=8376dfb0af8293dfbb1550aed3b614c9c681523b&fromchange=ef7547cbfdf858cb6c507e142d57fd4c3be17dac

Since then this is permafailling but only on debug: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=success&filter-searchStr=bmsvc&fromchange=4146a5857135b8542858b9e23bc5a71237e05f49&tochange=37b33c4f58b9372ad8d4fa969ad7a86ae305790a&selectedJob=192047664

Comment 4

[Intermittent Failures Robot]

16 failures in 80 pushes (0.2 failures/push) were associated with this bug yesterday.

Repository breakdown:
* try: 4
* mozilla-central: 12

Platform breakdown:
* windows2012-64: 8
* windows2012-32: 8

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1481005&startday=2018-08-05&endday=2018-08-05&tree=all

Comment 5

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

To add to the above, I'm seeing the changes from bug 1480624 lead to this issue with local MSVC builds. Verified by backing out the changes.

Highlighting the issue in comment #0 / the logs:

>>12:59:43     INFO -  xptcall.cpp
>>12:59:43     INFO -  z:\build\build\src\obj-firefox\dist\include\mozilla/Alignment.h(29): error C2220: warning treated as error - no 'object' file generated
>>12:59:43     INFO -  z:\build\build\src\obj-firefox\dist\include\mozilla/Alignment.h(32): note: see reference to class template instantiation 'mozilla::AlignmentFinder<nsXPTCVariant::ExtendedVal>::Aligner' being compiled
>>12:59:43     INFO -  z:\build\build\src\xpcom\reflect\xptcall\xptcall.h(126): note: see reference to class template instantiation 'mozilla::AlignmentFinder<nsXPTCVariant::ExtendedVal>' being compiled
>12:59:43     INFO -  z:\build\build\src\obj-firefox\dist\include\mozilla/Alignment.h(29): warning C4624: 'mozilla::AlignmentFinder<nsXPTCVariant::ExtendedVal>::Aligner': destructor was implicitly defined as deleted

Comment 6

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Looking a little deeper. Suspect MSVC is unhappy when it tries to handle one of the new lines[0] from bug 1480624. MOZ_ALIGNOF(nsXPTCVariant::ExtendedVal) -> AlignmentFinder with T=nsXPTCVariant::ExtendedVal -> Aligner with a nsXPTCVariant::ExtendedVal member. Since nsXPTCVariant::ExtendedVal has a deleted dtor, compiler decides that said specialisation of Aligner has an implicitly deleted dtor and we get this unhappiness.

[0]: https://searchfox.org/mozilla-central/rev/3fdc491e118c5cdfbaf6e2d52f3466d2b27ad1de/xpcom/reflect/xptcall/xptcall.h#124

Comment 7

[Intermittent Failures Robot]

25 failures in 350 pushes (0.071 failures/push) were associated with this bug yesterday.

Repository breakdown:
* mozilla-central: 15
* try: 10

Platform breakdown:
* windows2012-32: 13
* windows2012-64: 12

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1481005&startday=2018-08-06&endday=2018-08-06&tree=all

Comment 8

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=652e492d68964d36601892270e0bc6dbbdcd9f75

Comment 9

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1481005 - Explicitly delete dtor of AlignmentFinder::Alinger to avoid MSVC warning breaking debug builds.

Bug 1480624 added new code that results in a warning on MSVC debug builds. This
warning is treated as an error and makes such builds unhappy. The warning is
due to implicit deletion of a dtor, this changeset makes that deletion
explicit to avoid the fatal warning.

Comment 10

[Nika Layzell [:nika] (ni? for response)]

Thanks for figuring this out :bryce!

Comment 11

[Phabricator Automation]

Comment on attachment 8998234 [details]
Bug 1481005 - Explicitly delete dtor of AlignmentFinder::Alinger to avoid MSVC warning breaking debug builds.

Nathan Froyd [:froydnj] has approved the revision.

https://phabricator.services.mozilla.com/D2865

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76baf773b83e
Explicitly delete dtor of AlignmentFinder::Alinger to avoid MSVC warning breaking debug builds. r=froydnj

Comment 13

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/76baf773b83e

Comment 14

[Intermittent Failures Robot]

55 failures in 2561 pushes (0.021 failures/push) were associated with this bug in the last 7 days.

This is the #29 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* try: 16
* mozilla-central: 39

Platform breakdown:
* windows2012-64: 27
* windows2012-32: 28

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1481005&startday=2018-08-05&endday=2018-08-11&tree=all

Comment 15

[Intermittent Failures Robot]

39 failures in 2579 pushes (0.015 failures/push) were associated with this bug in the last 7 days.

This is the #49 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* mozilla-central: 27
* try: 12

Platform breakdown:
* windows2012-32: 20
* windows2012-64: 19

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1481005&startday=2018-08-06&endday=2018-08-12&tree=all