1481016 - Use inherent rust methods for to_ascii_uppercase and to_ascii_lowercase instead of std::ascii::AsciiExt

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Jeremy Lempereur [:o0ignition0o]]

Since 1.26 std::ascii::AsciiExt::to_ascii_lowercase and std::ascii::AsciiExt::to_ascii_uppercase got deprecated, which causes netwerk helper to fail due to warnings : 


> Compiling netwerk_helper v0.0.1 (file:///[...]mozilla-unified/netwerk/base/rust-helper)
> 0:43.78 warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead
>  0:44.24  --> netwerk\base\rust-helper\src\lib.rs:1:5
>  0:44.67   |
>  0:45.01 1 | use std::ascii::AsciiExt;
>  0:45.49   |     ^^^^^^^^^^^^^^^^^^^^

Comment 1

[Jeremy Lempereur [:o0ignition0o]]

Attachment: Bug 1481016 - Network, use inherent rust methods instead of deprecated std::ascii:AsciiExt ones,

Review commit: https://reviewboard.mozilla.org/r/261366/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/261366/

Comment 2

[Valentin Gosu [:valentin] (he/him) {{ FYI: OOO 14 June - 4 August }}]

Comment on attachment 8997673 [details]
Bug 1481016 - Network, use inherent rust methods instead of deprecated std::ascii:AsciiExt ones,

https://reviewboard.mozilla.org/r/261366/#review268444

Comment 3

[Jeremy Lempereur [:o0ignition0o]]

It seems like I don't have the right SCM level to trigger a try build / land patches.

AFAIR there's a specific flag I can switch on bmo to allow the patch to be autolanded after a while, but I can't find it :/

Comment 4

[Valentin Gosu [:valentin] (he/him) {{ FYI: OOO 14 June - 4 August }}]

The flag is checkin-needed?
I'll land the patch for you.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ffbddf32df5
Network, use inherent rust methods instead of deprecated std::ascii:AsciiExt ones, r=valentin

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6ffbddf32df5