Closed
Bug 1481031
Opened 6 years ago
Closed 6 years ago
Use Noto Serif CJK as the default serif fonts for Chinese, Japanese and Korean
Categories
(Core :: Layout: Text and Fonts, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: al2m025304, Assigned: jfkthame)
Details
Attachments
(1 file)
3.11 KB,
patch
|
m_kato
:
review+
|
Details | Diff | Splinter Review |
Android P has Noto Serif CJK as the default serif fonts for Chinese, Japanese and Korean, so we can add it to the font.name-lists.
Assignee | ||
Comment 1•6 years ago
|
||
This inserts the new Noto serif font after our bundled Charis, following the pattern we've used for other fonts. I wonder if that's something to reconsider; now that we no longer bundle our own sans-serif font, maybe it's not worth bundling/prioritizing the serif one either? But that's a question for a separate bug/discussion. While here, I also noticed and fixed a typo where we currently list Droid Sans Mono CJK JP, which doesn't actually exist; it was clearly meant to be a Noto name.
Attachment #8999131 -
Flags: review?(m_kato)
Assignee | ||
Updated•6 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3
Comment 2•6 years ago
|
||
Comment on attachment 8999131 [details] [diff] [review] Add Noto Serif CJK to android font prefs Review of attachment 8999131 [details] [diff] [review]: ----------------------------------------------------------------- Actually, since we still support Android 4.0 (API 16), some devices (such as Chinese device) uses Droid fonts for CJK (and OEM font). But, from Android 6.0, most devices has Noto Sans CJK for CJK font. So we need remove some fonts by GeckoView era since the base of this list is Android 2.2. > This inserts the new Noto serif font after our bundled Charis, following the pattern we've used for other fonts. I wonder if that's something to reconsider; now that we no longer bundle our own sans-serif font, maybe it's not worth bundling/prioritizing the serif one either? But that's a question for a separate bug/discussion. While here, I also noticed and fixed a typo where we currently list Droid Sans Mono CJK JP, which doesn't actually exist; it was clearly meant to be a Noto name. Hmm, after this change, it will be default font's metric is changed from Noto Serif to Noto Serif CJKs if Charis SIL Compact isn't downloaded/installed by DLC. But since most sites use sans-serif as default, a few sites might be affected. But this is OK at this time since Pixel is only device that has this font and Charis SIL Compact is installed as bundle. Also, We should add Noto Serif fonts to other language such as Noto Serif Thai by another bug.
Attachment #8999131 -
Flags: review?(m_kato) → review+
Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d0fd03694e57 Add Noto Serif CJK to android font prefs. r=m_kato
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d0fd03694e57
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Updated•6 years ago
|
Assignee: nobody → jfkthame
You need to log in
before you can comment on or make changes to this bug.
Description
•