Closed Bug 1481035 Opened 3 years ago Closed 3 years ago

Port Bug 1446748 "Convert the remaining non-photon design calendar icons" to SeaMonkey

Categories

(SeaMonkey :: Build Config, enhancement)

SeaMonkey 2.60 Branch
enhancement
Not set
normal

Tracking

(seamonkey2.57esr fixed, seamonkey2.60 fixed)

RESOLVED FIXED
seamonkey2.60
Tracking Status
seamonkey2.57esr --- fixed
seamonkey2.60 --- fixed

People

(Reporter: frg, Assigned: frg)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

This needs installer changes and some icons copied into our tree.
This works but after just getting rid of makefile.in in branding lets see if we can do the same here first.
I like this one more.
Attachment #8997706 - Flags: review?(iann_bugzilla)
Attachment #8997706 - Flags: approval-comm-esr60?
Comment on attachment 8997706 [details] [diff] [review]
1481035-calendaricons_v2.patch

>+++ b/suite/app/icons/moz.build
>@@ -0,0 +1,23 @@
>+# vim: set filetype=python:
>+# This Source Code Form is subject to the terms of the Mozilla Public
>+# License, v. 2.0. If a copy of the MPL was not distributed with this
>+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
>+
>+if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'windows':
>+    icon_suffix = '.ico'
>+    icon_dir = CONFIG['MOZ_WIDGET_TOOLKIT']
>+
>+    # Windows icons
>+    desktop_icons = [
>+        'calendar-alarm-dialog',
>+        'calendar-event-dialog',
>+        'calendar-event-summary-dialog',
>+        'calendar-task-dialog',
>+        'calendar-task-summary-dialog',
>+    ]
>+
>+    FINAL_TARGET_FILES.chrome.icons.default += [
>+        '%s/%s%s' % (icon_dir, i, icon_suffix) for i in sorted(
>+            desktop_icons
>+        )
>+    ]
Any reason why this isn't being done in suite/branding/branding-common.mozbuild?

r/a=me with that answered/addressed
Attachment #8997706 - Flags: review?(iann_bugzilla)
Attachment #8997706 - Flags: review+
Attachment #8997706 - Flags: approval-comm-esr60?
Attachment #8997706 - Flags: approval-comm-esr60+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/e1f1bb54ed97
Add calendar icons to SeaMonkey installer. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
https://hg.mozilla.org/releases/comm-esr60/rev/213d8f29e9f009fd2dce990c3622d4fb95e2e1c8


> Any reason why this isn't being done in suite/branding/branding-common.mozbuild?

As discussed on irc. The icons are not branded. This is currently be a mood point because we have only one branding but maybe in the future...

In any case makes it easier to add unbranded icons or images later because this can be extended easily now and it is closer to how TB does it right now.
Target Milestone: --- → seamonkey2.60
You need to log in before you can comment on or make changes to this bug.