1481035 - Port Bug 1446748 "Convert the remaining non-photon design calendar icons" to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, enhancement)

Description

[Frank-Rainer Grahl (:frg)]

This needs installer changes and some icons copied into our tree.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1481035-calendaricons.patch

This works but after just getting rid of makefile.in in branding lets see if we can do the same here first.

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: 1481035-calendaricons_v2.patch

I like this one more.

Comment 3

[Ian Neal]

Comment on attachment 8997706 [details] [diff] [review]
1481035-calendaricons_v2.patch

>+++ b/suite/app/icons/moz.build
>@@ -0,0 +1,23 @@
>+# vim: set filetype=python:
>+# This Source Code Form is subject to the terms of the Mozilla Public
>+# License, v. 2.0. If a copy of the MPL was not distributed with this
>+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
>+
>+if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'windows':
>+    icon_suffix = '.ico'
>+    icon_dir = CONFIG['MOZ_WIDGET_TOOLKIT']
>+
>+    # Windows icons
>+    desktop_icons = [
>+        'calendar-alarm-dialog',
>+        'calendar-event-dialog',
>+        'calendar-event-summary-dialog',
>+        'calendar-task-dialog',
>+        'calendar-task-summary-dialog',
>+    ]
>+
>+    FINAL_TARGET_FILES.chrome.icons.default += [
>+        '%s/%s%s' % (icon_dir, i, icon_suffix) for i in sorted(
>+            desktop_icons
>+        )
>+    ]
Any reason why this isn't being done in suite/branding/branding-common.mozbuild?

r/a=me with that answered/addressed

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e1f1bb54ed97
Add calendar icons to SeaMonkey installer. r=IanN

Comment 5

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-esr60/rev/213d8f29e9f009fd2dce990c3622d4fb95e2e1c8


> Any reason why this isn't being done in suite/branding/branding-common.mozbuild?

As discussed on irc. The icons are not branded. This is currently be a mood point because we have only one branding but maybe in the future...

In any case makes it easier to add unbranded icons or images later because this can be extended easily now and it is closer to how TB does it right now.