1481056 - New progress bar overlays/covers old one in Add-ons Manager/about:addons

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: bug.png

STR:
1. Go to Add-ons Manager/about:addons and press there "Tools for all add-ons" (sprocket-wheel) button to see menu and disable "Update Add-ons Automatically"
2. Install older version of uBlock Origin extension  ( https://addons.mozilla.org/en-US/firefox/addon/ublock-origin/versions/ )
3. Go again to Add-ons Manager/about:addons and press "Tools for all add-ons" (sprocket-wheel) button to see menu and press "Check for updates"
and see that new progress bar overlays/covers old one in Add-ons Manager/about:addons (check attachment for how it looks like)

Looks like regression from about max. 1-2 weeks.

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=8d4b97056365e3db6c03960f5287577c3be06182&tochange=9ce00184b215f40a67305f7dff3b1abe6fc8df02

Regressed by:
9ce00184b215	Paolo Amadini — Bug 1473931 - Load "progressmeter.css" as a document stylesheet. r=bgrins

Comment 2

[:Paolo Amadini]

Attachment: Bug 1481056 - Don't reuse the "progressmeter" element for the custom "download-progress" binding. r=mossop

Comment 3

[:Paolo Amadini]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5e3727f312b3b512c27f30e28414a629782adbb

Comment 4

[:Paolo Amadini]

Tested on Mac. :Virtual, can you check the patch or a tryserver build to see if it solves the problem on Windows as well?

Comment 5

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Thank you very much Alice0775 White for finding specific regression range.
Thank you very much Paolo Amadini for fast fix, works fine here on Windows 7 (64-bit) with Mozilla Firefox Nightly 63.0a1 (2018-08-06) (64-bit) [ Built from https://hg.mozilla.org/try/rev/e5e3727f312b3b512c27f30e28414a629782adbb ].

Comment 6

[Phabricator Automation]

Comment on attachment 8997824 [details]
Bug 1481056 - Don't reuse the "progressmeter" element for the custom "download-progress" binding. r=mossop

Dave Townsend [:mossop] has approved the revision.

https://phabricator.services.mozilla.com/D2769

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b217f7111748
Don't reuse the "progressmeter" element for the custom "download-progress" binding. r=mossop

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/b217f7111748

Comment 9

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 63.0a1 (2018-08-08). Thank you very much. \o/