1481061 - Some elements are still LTR after bug 1480798

Status: RESOLVED WORKSFORME

(Firefox :: General, defect, P2)

Description

[Itiel]

Following bug 1480798.

See attachment 8997716 [details], now most of the UI is RTL but the "Remove All Reports" button and "Report ID" text are still LTR.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Can you attach a screenshot of the issue?

Comment 2

[Itiel]

(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #1)
> Can you attach a screenshot of the issue?

I did. See first comment.

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Hmm, I guess I'm struggling to understand what do you mean by LTR. 

The phrase `Remove All Reports` in l10n-central [0] and in the screenshot is in the same direction as `Unsubmitted Crash Reports` phrase is.

Which means, as far as I understand, that either both of those phrases are LTR or both of them are RTL.

Are you referring to items layout in the document rather than text directionality? If so, can you help me understand how the layout is expected to look like?

I apologize for my ignorance, but in order to understand what causes the bug I need a bit more information.

[0] https://hg.mozilla.org/l10n-central/he/file/tip/toolkit/crashreporter/aboutcrashes.ftl

Comment 4

[Itiel]

Text directionality is fine here. I was referring to the items layout, as you said.
It should look like the attached screenshot, taken from 62.0b14.

Comment 5

[Itiel]

Attachment: Correct about:crashes

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Thank you Itel!

Alexis - this may actually be an issue with CSS enforcing LTR layout and you may want to either de-hardcode ltr assumptions or separate out ltr and rtl based on `html[dir=ltr]` and `html[dir=rtl]`

Comment 7

[Alexis Deschamps [:alexisdeschamps]]

I have a fix in https://phabricator.services.mozilla.com/D2792. I am using the suggestion from Zibi to use html[dir=ltr].

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

Cool! Just in case - if you want to test the RTL you can use pseudolocales with strategy `bidi` - https://diary.braniecki.net/2018/06/07/pseudolocalization-in-firefox/

Comment 9

[Zibi Braniecki [:zbraniecki][:gandalf]]

This is part of the about:crashes UI, not platform:intl.

Comment 10

[Itiel]

about:crashes is fine now. If I'm not mistaken this was solved by another about:crashes bug.