1481094 - PROCESS-CRASH | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_downloads_download.js

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[Jorg K (CEST = GMT+2)]

PROCESS-CRASH | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_downloads_download.js | application crashed [@ nsBaseFilePicker::Init(mozIDOMWindowProxy*, nsTSubstring<char16_t> const&, short)]
PID 1613 | Assertion failure: aParent (Null parent passed to filepicker, no file picker for you!), at /builds/worker/workspace/build/src/widget/nsBaseFilePicker.cpp:173

Strangely only crashing on Mac and Linux.

First seen: Fri, Aug 3, 2018, 20:28:25
M-C last good: b1c100e2b29a8e671678eb537ba69badc2
M-C first bad: 3d107866825433ab1168c7d23e94eac727
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b1c100e2b29a8e671678eb537ba69badc2&tochange=3d107866825433ab1168c7d23e94eac727

Most likely caused be over-zealously re-enabling the test here:
https://hg.mozilla.org/mozilla-central/rev/163742dd3235#l1.32

Not only does it fail (as expected), it also crashes which is not so convenient :-(

Geoff, can we get this switched off again?

Comment 1

[Geoff Lankow (:darktrojan)]

Well here's the problem:

> const window = Services.wm.getMostRecentWindow("navigator:browser");

https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/extensions/parent/ext-downloads.js#l518

I really wish they wouldn't do that. I'll see if I can make a change that will work.

Comment 2

[Geoff Lankow (:darktrojan)]

No I won't, I'll just skip it. Wasn't aware a crash didn't count as failing.

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: 1481094-skip-tests-1.diff

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b4811b887650
Skip all downloads tests on Thunderbird; r=aswan

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/b4811b887650