Closed
Bug 1481096
Opened 6 years ago
Closed 6 years ago
typo in usage of "network.http.spdy.default-hpack-buffer"
Categories
(Core :: Networking: HTTP, enhancement, P1)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: arthur, Assigned: arthur)
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
|
1.18 KB,
patch
|
u408661
:
review+
|
Details | Diff | Splinter Review |
The pref handling here is incorrect, because the pref name suffix is "spdy.default-hpack-buffer", not "spdy.hpack-default-buffer": https://dxr.mozilla.org/mozilla-central/rev/4e56a2f51ad739ca52046723448f3129a58f1666/netwerk/protocol/http/nsHttpHandler.cpp#1999
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8997755 -
Flags: review?(hurley)
|
||
Updated•6 years ago
|
Assignee: nobody → arthuredelstein
Priority: -- → P1
Whiteboard: [necko-triaged]
Comment on attachment 8997755 [details] [diff] [review] 0001-Bug-1481096-Fix-incorrectly-written-pref-name.patch Review of attachment 8997755 [details] [diff] [review]: ----------------------------------------------------------------- Woo, that's a doozy of a foul up. Thanks for catching it!
Attachment #8997755 -
Flags: review?(hurley) → review+
Pushed by apavel@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9b0307cc5173 Fix incorrectly written pref name r=nwgh
Keywords: checkin-needed
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9b0307cc5173
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•