Closed Bug 1481098 Opened Last year Closed 11 months ago

Remove Unused aParentContext Parameter in ServoStyleSet::ResolveStyleFor Function

Categories

(Core :: Layout, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: yusuf, Assigned: jeanluc.bonnafoux, Mentored)

Details

Attachments

(1 file)

In ServoStyleSet::ResolveStyleFor, the parameter "ComputedStyle* aParentContext" seems like it's not being used anymore (I think it was used for ServoStyleSet::GetContext, which's also not there anymore), if I'm not missing something.

https://searchfox.org/mozilla-central/source/layout/style/ServoStyleSet.cpp#379
Remove Unused aParentContext Parameter in ServoStyleSet::ResolveStyleFor Function
Comment on attachment 9009469 [details]
Bug 1481098 - Remove Unused aParentContext Parameter in ServoStyleSet::ResolveStyleFor Function

David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-7 has approved the revision.
Attachment #9009469 - Flags: review+
Hello,
Thanks for the reviews.
Could you please assign this bug to me?
Thanks,
Assignee: nobody → jeanluc.bonnafoux
Status: NEW → ASSIGNED
Keywords: checkin-needed
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b0fe36c3965f
Remove Unused aParentContext Parameter in ServoStyleSet::ResolveStyleFor Function r=dbaron
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b0fe36c3965f
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.