Closed Bug 1481176 Opened Last year Closed Last year

Enable media-capabilities for wpt

Categories

(Core :: Audio/Video: Playback, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: jya, Assigned: jya)

References

Details

Attachments

(5 files)

For some reasons some of the WPT media-capabilities test didn't enable media-capabilities flag..

Additionally, this reveals assertions error with the test in workers that expect to only ever be called on the main thread.
nsContentTypeParser used internally a nsIMIMEHeaderParam reference, effectively limiting its use on the main thread, and as such restricting any methods handling mime type there too.

nsContentTypeParser only made use of a single method nsMIMEHeaderParamImpl::GetParameterHTTP, so we make that method static and export it.

It's not the most elegant way to do things, however the alternatives would be either much more intrusive or would require to duplicate lots of code.

We also give nsContentTypeParser its own code file.
This is done by ensuring that all methods is called are usable off the main thread and creating the required preference accessors.

Depends on https://phabricator.services.mozilla.com/D2788
Comment on attachment 8997943 [details]
Bug 1481176 - P4. Enable more media-capabilities wpt. r?jgraham

James Graham [:jgraham] has approved the revision.

https://phabricator.services.mozilla.com/D2791
Attachment #8997943 - Flags: review+
Attachment #8997939 - Attachment description: Bug 1481176 - P1. Export GetParameterHTTP as static method. r?froydnj → Bug 1481176 - P1. Export GetParameterHTTP as static method.
Also move nsContentType code into its own file, it will simplify future changes.

Depends on D2788
Attachment #8997942 - Attachment description: Bug 1481176 - P2. Make CanHandleMediaType usable off the main thread. r?bryce → Bug 1481176 - P3. Make CanHandleMediaType usable off the main thread. r?bryce
Attachment #8997943 - Attachment description: Bug 1481176 - P3. Enable more media-capabilities wpt. r?jgraham → Bug 1481176 - P4. Enable more media-capabilities wpt. r?jgraham
Comment on attachment 8997939 [details]
Bug 1481176 - P1. Export GetParameterHTTP as static method.

Valentin Gosu [:valentin] has approved the revision.

https://phabricator.services.mozilla.com/D2788
Attachment #8997939 - Flags: review+
Comment on attachment 8997942 [details]
Bug 1481176 - P3. Make CanHandleMediaType usable off the main thread. r?bryce

Bryce Seager van Dyk (:bryce) has approved the revision.

https://phabricator.services.mozilla.com/D2790
Attachment #8997942 - Flags: review+
Comment on attachment 8998226 [details]
Bug 1481176 - P3. Remove nsIMIMEHeaderParam dependency in nsContentTypeParser. r?bz

Boris Zbarsky [:bz] (no decent commit message means r-) has approved the revision.

https://phabricator.services.mozilla.com/D2863
Attachment #8998226 - Flags: review+
Comment on attachment 8998009 [details]
Bug 1481176 - P2. Remove nsIMIMEHeaderParam dependency in nsContentTypeParser. r?froydnj

Boris Zbarsky [:bz] (no decent commit message means r-) has approved the revision.

https://phabricator.services.mozilla.com/D2800
Attachment #8998009 - Flags: review+
Comment on attachment 8997939 [details]
Bug 1481176 - P1. Export GetParameterHTTP as static method.

Boris Zbarsky [:bz] (no decent commit message means r-) has approved the revision.

https://phabricator.services.mozilla.com/D2788
Attachment #8997939 - Flags: review+
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9027bf257d23
P1. Export GetParameterHTTP as static method. r=valentin,r=bzbarsky
https://hg.mozilla.org/integration/mozilla-inbound/rev/046c09c65b4a
P2. Move nsContentTypeParser to its own file. r=bzbarsky
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce551bb46aa2
P3. Remove nsIMIMEHeaderParam dependency in nsContentTypeParser. r=bzbarsky
https://hg.mozilla.org/integration/mozilla-inbound/rev/cbc8352f9578
P4. Make CanHandleMediaType usable off the main thread. r=bryce
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ea09ec0a7e6
P5. Enable more media-capabilities wpt. r=jgraham
You need to log in before you can comment on or make changes to this bug.