Closed
Bug 1481195
Opened 6 years ago
Closed 6 years ago
Fix nav2_test_attributes_values.html WPT
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
Details
Attachments
(1 file)
1.75 KB,
patch
|
valentin
:
review+
|
Details | Diff | Splinter Review |
This test still fails because we don't allow the current origin to have access to the PerformanceTiming data coming from the channel of the current document.
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #8997864 -
Flags: review?(valentin.gosu)
Comment 2•6 years ago
|
||
Comment on attachment 8997864 [details] [diff] [review] performance_WPT.patch Review of attachment 8997864 [details] [diff] [review]: ----------------------------------------------------------------- This looks good. As a side note, can you also check if we properly handle point 20 of https://www.w3.org/TR/navigation-timing-2/#processing-model ? It seems to me that we have a bug, at least for .redirectCount, as we check if mAllRedirectsSameOrigin instead of mReportCrossOriginRedirect
Attachment #8997864 -
Flags: review?(valentin.gosu) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/96a7f93d60a9 The current document should have access to its PerformanceTimingData, r=valentin
Assignee | ||
Comment 4•6 years ago
|
||
> As a side note, can you also check if we properly handle point 20 of
> https://www.w3.org/TR/navigation-timing-2/#processing-model ?
> It seems to me that we have a bug, at least for .redirectCount, as we check
> if mAllRedirectsSameOrigin instead of mReportCrossOriginRedirect
Yes, this is the last remaining WPT failures. I'll take a look in the next days.
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/96a7f93d60a9
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•