Closed
Bug 1481229
Opened 6 years ago
Closed 6 years ago
Remove remaining JSAutoRealmAllowCCW uses in js/ipc
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(2 files)
|
1.23 KB,
patch
|
evilpie
:
review+
|
Details | Diff | Splinter Review |
|
1.37 KB,
patch
|
evilpie
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•6 years ago
|
||
ToWindowProxyIfWindow does not rely on the current realm in any way.
Attachment #8997902 -
Flags: review?(evilpies)
|
|
Assignee | |
Comment 2•6 years ago
|
||
The code already called UncheckedUnwrap unconditionally on |obj| so I removed the null check because before this patch it would always crash in that case.
Attachment #8997911 -
Flags: review?(evilpies)
|
||
Updated•6 years ago
|
Component: IPC → JavaScript Engine
|
||
Updated•6 years ago
|
Attachment #8997902 -
Flags: review?(evilpies) → review+
|
|
||
Comment 3•6 years ago
|
||
Comment on attachment 8997911 [details] [diff] [review] Part 2 - Always use the unwrapped object in Logging::formatObject Review of attachment 8997911 [details] [diff] [review]: ----------------------------------------------------------------- A bit weird, but whatever this code is not critical.
Attachment #8997911 -
Flags: review?(evilpies) → review+
Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/de88f2fd6d4d part 1 - Remove unnecessary realm entering in JavaScriptShared::findObjectById. r=evilpie https://hg.mozilla.org/integration/mozilla-inbound/rev/7791fe11b664 part 2 - Always use the unwrapped object in Logging::formatObject. r=evilpie
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/de88f2fd6d4d https://hg.mozilla.org/mozilla-central/rev/7791fe11b664
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•