Closed Bug 1481229 Opened Last year Closed Last year

Remove remaining JSAutoRealmAllowCCW uses in js/ipc

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(2 files)

No description provided.
ToWindowProxyIfWindow does not rely on the current realm in any way.
Attachment #8997902 - Flags: review?(evilpies)
The code already called UncheckedUnwrap unconditionally on |obj| so I removed the null check because before this patch it would always crash in that case.
Attachment #8997911 - Flags: review?(evilpies)
Component: IPC → JavaScript Engine
Attachment #8997902 - Flags: review?(evilpies) → review+
Comment on attachment 8997911 [details] [diff] [review]
Part 2 - Always use the unwrapped object in Logging::formatObject

Review of attachment 8997911 [details] [diff] [review]:
-----------------------------------------------------------------

A bit weird, but whatever this code is not critical.
Attachment #8997911 - Flags: review?(evilpies) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/de88f2fd6d4d
part 1 - Remove unnecessary realm entering in JavaScriptShared::findObjectById. r=evilpie
https://hg.mozilla.org/integration/mozilla-inbound/rev/7791fe11b664
part 2 - Always use the unwrapped object in Logging::formatObject. r=evilpie
https://hg.mozilla.org/mozilla-central/rev/de88f2fd6d4d
https://hg.mozilla.org/mozilla-central/rev/7791fe11b664
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.