Closed
Bug 1481239
Opened 6 years ago
Closed 6 years ago
fix non-DEBUG VIXL_UNREACHABLE
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
|
1.39 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
MOZ_MAKE_COMPILER_ASSUME_IS_UNREACHABLE takes a reason string, which wasn't being provided, which in turn led to a lot of warning spam.
|
Assignee | |
Comment 1•6 years ago
|
||
This is only a problem for aarch64 windows builds, apparently? I am surprised that gcc/clang don't warn or error on this.
Attachment #8997933 -
Flags: review?(jdemooij)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8997933 [details] [diff] [review] fix non-DEBUG VIXL_UNREACHABLE Review of attachment 8997933 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8997933 -
Flags: review?(jdemooij) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/47cfdd30d8d3 fix non-DEBUG VIXL_UNREACHABLE; r=jandem
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/47cfdd30d8d3
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•