1481244 - Crash in <name omitted> | mozilla::AudioStream::SetVolume

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect, P2)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is
report bp-e5940041-858e-40d4-a3b1-d2fc60180804.
=============================================================

Seen while looking at crash stats - several of these crashes spotted in the latest 10.14 seed: https://bit.ly/2M4vLbd. There is also a set which affects 62: https://bit.ly/2vHxskS

The crash reason for all crashes in these 2 signatures is EXC_SOFTWARE / SIGABRT.

Top 10 frames of crashing thread:

0  @0x7fff57f48a86 
1 XUL google_breakpad::ReceivePort::WaitForMessage toolkit/crashreporter/google-breakpad/src/common/mac/MachIPC.mm:249
2 XUL google_breakpad::CrashGenerationClient::RequestDumpForException toolkit/crashreporter/breakpad-client/mac/crash_generation/crash_generation_client.cc:67
3 XUL google_breakpad::ExceptionHandler::WriteMinidumpWithException toolkit/crashreporter/breakpad-client/mac/handler/exception_handler.cc:375
4 XUL google_breakpad::ExceptionHandler::SignalHandler toolkit/crashreporter/breakpad-client/mac/handler/exception_handler.cc:621
5  @0x7fff57fe4d79 
6  @0x1196088c7 
7  @0x7fff57ea51c8 
8  @0x7fff57e6d867 
9 XUL <name omitted> media/libcubeb/src/cubeb_audiounit.cpp:2868

=============================================================

Comment 1

[Paul Adenot (:padenot)]

This is crashing on OSX because `stm->output_unit` is `nullptr`.

Comment 2

[[:philipp]]

fairly low volume & devedition/nightly users are hit most commonly by this.

Comment 3

[Pascal Chevrel:pascalc]

No crash on 63, a handful of crashes on 64 beta and 65 nightly.

Comment 4

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Low volume crash, has a priority set. 
Marking fix-optional to remove this from regression triage. 
Happy to still take a patch in nightly.

Comment 6

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1481244 - When a stream is errored avoid updating the volume. r?jya

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ece70ee50ed6
When a stream is errored avoid updating the volume. r=jya

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ece70ee50ed6

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider for Beta backport or can it ride the trains?

Comment 10

[Alex Chronopoulos [:achronop]]

Yeah, that's something I would like to uplift and it is fairly small and uplift-able.

Comment 11

[Alex Chronopoulos [:achronop]]

Attachment: bug-1481244-beta-uplift.patch

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: None
• User impact if declined: A crash when an audio stream fails.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a small fix that prevents volume changes on a failed stream.
• String changes made/needed:

Comment 12

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 9046307 [details] [diff] [review]
bug-1481244-beta-uplift.patch

Avoids a potential crash, low risk, OK for beta 12 uplift.

Comment 13

[Razvan Maries]

https://hg.mozilla.org/releases/mozilla-beta/rev/edb0544758a7