Closed Bug 1481340 Opened 2 years ago Closed 2 years ago

Disallow implicitly enabling both Tup and Make backends

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: chmanchester, Assigned: chmanchester)

References

Details

(Keywords: in-triage)

Attachments

(1 file, 1 obsolete file)

If we have "--enable-build-backend=Tup" passed to configure vs. "--enable-build-backends=Tup" we end up adding Tup to the default set of backends, which includes Make. So we get an objdir with both Makefiles and Tupfiles, but somewhere along the line |./mach build| will end up executing Make instead of tup.

The names of these two options are confusing but moreover adding the Tup backend to the Make backend isn't going to yield a useful result and probably shouldn't be allowed at all.
Keywords: in-triage
Assignee: nobody → cmanchester
Attachment #8998434 - Attachment is obsolete: true
Comment on attachment 8998431 [details]
Bug 1481340 - Don't generate combinations of make and tup backends in configure.

Gregory Szorc [:gps] has approved the revision.
Attachment #8998431 - Flags: review+
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1a93db801952
Don't generate combinations of make and tup backends in configure. r=gps,firefox-build-system-reviewers
https://hg.mozilla.org/mozilla-central/rev/1a93db801952
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.