1481378 - Simplify mozconfig.linux32

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Simplify mozconfig.linux32

All CI builds for linux32 have been running on 64-bits hosts for a long
while now, and there are no 32-bits hosts left. We can remove the
special-casing that makes the linux32 builds behave differently
depending on the bit-width of the host.

Furthermore, configure has been able to deal with adding -m32 on its
own, so we don't need to add it to $CC/$CXX manually anymore.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8998104 [details] [diff] [review]
Simplify mozconfig.linux32

Review of attachment 8998104 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/unix/mozconfig.linux32
@@ +7,3 @@
>  
> +ac_add_options --target=i686-pc-linux
> +ac_add_options --host=i686-pc-linux

I've never understood why we have the host set to x86 for these builds as well. Is that also just leftover from the time of 32-bit build machines?

Comment 3

[Mike Hommey [:glandium]]

This is why:
https://bugzilla.mozilla.org/show_bug.cgi?id=462427#c3

Things have significantly changed since then, it might work just fine without --host. I'll leave it like that for now, though.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef7f43b981ef
Simplify mozconfig.linux32. r=ted

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/ef7f43b981ef