Closed
Bug 1481399
Opened 6 years ago
Closed 6 years ago
rename nsAttrAndChildArray
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: smaug, Assigned: smaug)
References
Details
Attachments
(2 files)
85.65 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
85.65 KB,
patch
|
Details | Diff | Splinter Review |
Assuming the change to use nsAttrAndChildArray only for attrs won't be backed out, we should rename it to AttrArray or some such.
Assignee | ||
Comment 1•6 years ago
|
||
bug 1469521 landed recently, and assuming there are no too bad regressions, we should start to clean up the code a bit. This is the first bit. Only renaming and some minor coding style fixes. Try push is in bug 1481501
Attachment #8998233 -
Flags: review?(mrbkap)
Comment 2•6 years ago
|
||
Comment on attachment 8998233 [details] [diff] [review] attrarray.diff Review of attachment 8998233 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/html/nsGenericHTMLElement.cpp @@ +113,5 @@ > > bool reparse = (aDst->OwnerDoc() != OwnerDoc()); > > + rv = static_cast<nsGenericHTMLElement*>(aDst)->mAttrs. > + EnsureCapacityToClone(mAttrs, aPreallocateChildren); This indentation is weird.
Attachment #8998233 -
Flags: review?(mrbkap) → review+
Assignee | ||
Comment 3•6 years ago
|
||
it is. I can fix that existing weirdness while I'm there.
Assignee | ||
Comment 4•6 years ago
|
||
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3f144275839d rename nsAttrAndChildArray to AttrArray, r=mrbkap
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3f144275839d
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•