1481399 - rename nsAttrAndChildArray

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Olli Pettay [:smaug][[e-mail]]]

Assuming the change to use nsAttrAndChildArray only for attrs won't be backed out, we should rename it to AttrArray or some such.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: attrarray.diff

bug 1469521 landed recently, and assuming there are no too bad regressions, we should start to clean up the code a bit. This is the first bit.
Only renaming and some minor coding style fixes.
Try push is in bug 1481501

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8998233 [details] [diff] [review]
attrarray.diff

Review of attachment 8998233 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/html/nsGenericHTMLElement.cpp
@@ +113,5 @@
>  
>    bool reparse = (aDst->OwnerDoc() != OwnerDoc());
>  
> +  rv = static_cast<nsGenericHTMLElement*>(aDst)->mAttrs.
> +       EnsureCapacityToClone(mAttrs, aPreallocateChildren);

This indentation is weird.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

it is. I can fix that existing weirdness while I'm there.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: attrarray_2.diff

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f144275839d
rename nsAttrAndChildArray to AttrArray, r=mrbkap

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3f144275839d