when less than 501 messages are selected and mail.operate_on_msgs_in_collapsed_threads is true, «Note: XXX messages are selected, the first 500 are shown» shouldn’t be displayed if XXX <= 500
Categories
(Thunderbird :: Mail Window Front End, defect)
Tracking
(Not tracked)
People
(Reporter: aria, Assigned: aria)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:62.0) Gecko/20100101 Firefox/62.0
Build ID: 20180803111934
Steps to reproduce:
With Thunderbird 52.9.1, I selected all (292) messages in a folder.
Actual results:
I got the message:
> These messages take up 6.3 MB. (Note: 292 messages are selected, the first 500 are shown)
Expected results:
It feels weird to display this text when the number of messages is under 500.
It should not have displayed «the first 500 are shown».
|
||
Updated•6 years ago
|
|
||
Updated•6 years ago
|
|
||
Updated•4 years ago
|
So I checked what the bug actually was.
It seems that the code to summarize the multi-selection view was copied from the code to summarize a thread. But in the second case, it checks both for the limit of 500 messages and the limit of 100 threads.
It displays the same notice in both cases, so in «Note: XXX messages are selected, the first 500 are shown», XXX is always the number of messages. So when you select more than 100 threads but less than 500 messages, the notice will be displayed with inconsistent numbers.
See here for the code I talk about:
https://dxr.mozilla.org/comm-central/rev/2a29ee0adb310b54a6a2df72034953fed8f2b043/comm/mail/base/content/multimessageview.js#625-626,643-646
So the real problem is more that the notice is plainly incorrect in these cases, I edited the bug’s title to reflect that.
|
||
Updated•4 years ago
|
|
||
Comment 5•4 years ago
|
||
Ariasuni, you should add a reviewer to get this bug further. :mkmelin could be a candidate.
I added the reviewer you mentioned. Should the bug not be closed until the patch is merged, though?
|
|
||
Comment 7•4 years ago
|
||
(In reply to ariasuni from comment #6)
Should the bug not be closed until the patch is merged, though?
No, the bug will be closed when the patch lands.
|
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/7cd276439a22
Fix notice saying more messages are displayed than selected. r=Paenglab
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/4c63520cf276 follow-up - Fix not-defined variable. rs=linting DONTBUILD
Description
•