Closed
Bug 1481484
Opened 7 years ago
Closed 7 years ago
Type Scope::data_ and remove some reinterpret_casts
Categories
(Core :: JavaScript Engine, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file, 1 obsolete file)
|
18.24 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
At the moment Scope::data_ is a uintptr_t but I don't see any reason it can't be a BaseScopeData*.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8998211 -
Flags: review?(jdemooij)
|
|
Assignee | |
Comment 2•7 years ago
|
||
I found some more reinterpret_casts.
Attachment #8998211 -
Attachment is obsolete: true
Attachment #8998211 -
Flags: review?(jdemooij)
Attachment #8998232 -
Flags: review?(jdemooij)
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8998232 [details] [diff] [review]
bug1481484-scope-data
Review of attachment 8998232 [details] [diff] [review]:
-----------------------------------------------------------------
Cool!
Attachment #8998232 -
Flags: review?(jdemooij) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cd9715a55cb9
Type Scope::data_ r=jandem
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•