Bug 1481399 will rename the class and some clean ups will happen here. No doubt there are still more stuff to simplify. ATTRCHILD_ARRAY_MAX_ATTR_COUNT isn't needed since AddAttrSlot will do the check now that the array stores only attrs, not child nodes. CanFitMoreAttrs() isn't needed either for the same reason. searching for changes remote: adding changesets remote: adding manifests remote: adding file changes remote: added 2 changesets with 31 changes to 28 files (+1 heads) remote: recorded push in pushlog remote: remote: View your changes here: remote: https://hg.mozilla.org/try/rev/ed961def65099d39a30ef6e8c1476ad3033c1361 remote: https://hg.mozilla.org/try/rev/739c792f41fa28fdbc237b845eb4163a3852bf61 remote: remote: Follow the progress of your build on Treeherder: remote: https://treeherder.mozilla.org/#/jobs?repo=try&revision=739c792f41fa28fdbc237b845eb4163a3852bf61 remote: recorded changegroup in replication log in 0.009s
Comment on attachment 8998231 [details] [diff] [review] attrarray_cleanups.diff see comment 0. The patch is on top of the patch for bug 1481399
Attachment #8998231 - Flags: review?(mrbkap)
Attachment #8998231 - Flags: review?(mrbkap) → review+
ahaa, we have a test relying on the rather limited number of attrs currently allowed. https://searchfox.org/mozilla-central/source/dom/base/test/test_bug614583.html Need to remove that, it just isn't valid anymore and it times out.
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/65b80957568d cleanup AttrArray, r=mrbkap
You need to log in before you can comment on or make changes to this bug.