Closed
Bug 1481515
Opened 6 years ago
Closed 6 years ago
provide libvpx configuration(s) for aarch64 windows
Categories
(Core :: Audio/Video, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
66.49 KB,
patch
|
jya
:
review+
dminor
:
review+
|
Details | Diff | Splinter Review |
Otherwise media/libvpx/libvpx/vp8/common/threading.h thinks we are on a POSIX-y operating system and tries to include <semaphore.h>.
|
||
Updated•6 years ago
|
Rank: 25
Priority: -- → P3
|
Assignee | |
Comment 1•6 years ago
|
||
The new configuration is just config/generic, but indicating that we're MSVC, not GCC, and as such we don't have pthreads.
Attachment #9007042 -
Flags: review?(padenot)
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → nfroyd
|
|
Assignee | |
Comment 2•6 years ago
|
||
Whoops, forgot the moz.build changes!
Attachment #9007045 -
Flags: review?(padenot)
|
|
Assignee | |
Updated•6 years ago
|
Attachment #9007042 -
Attachment is obsolete: true
Attachment #9007042 -
Flags: review?(padenot)
|
||
Comment 3•6 years ago
|
||
Comment on attachment 9007045 [details] [diff] [review] add a libvpx config for aarch64 windows Looks ok, but jya probably knows this a bit better?
Attachment #9007045 -
Flags: review?(padenot) → review?(jyavenard)
|
||
Comment 4•6 years ago
|
||
Comment on attachment 9007045 [details] [diff] [review] add a libvpx config for aarch64 windows Review of attachment 9007045 [details] [diff] [review]: ----------------------------------------------------------------- LGTM :dminor should have a look.
Attachment #9007045 -
Flags: review?(jyavenard)
Attachment #9007045 -
Flags: review?(dminor)
Attachment #9007045 -
Flags: review+
|
|
||
Comment 5•6 years ago
|
||
Comment on attachment 9007045 [details] [diff] [review] add a libvpx config for aarch64 windows Review of attachment 9007045 [details] [diff] [review]: ----------------------------------------------------------------- lgtm as well
Attachment #9007045 -
Flags: review?(dminor) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0d844a92b327 add a libvpx config for aarch64 windows; r=padenot,jya,dminor
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0d844a92b327
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•