Update lldbinit to summarise nsAtom

RESOLVED FIXED in Firefox 63

Status

()

enhancement
P3
normal
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: mossop, Assigned: mossop)

Tracking

unspecified
mozilla63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

The current summary string doesn't work since nsAtom changed.

https://searchfox.org/mozilla-central/source/.lldbinit#25
Tom, do you know if we can just change that line to call a method on the atom instead, or does calling methods imply that we have to move to a more complicated printer for nsAtom?
Blocks: 1447951, 1411469
Flags: needinfo?(ttromey)
Priority: -- → P3
Assignee

Comment 3

10 months ago
Not quite sure this is right, but it seems to give the right results. Who could review this?

Comment 4

10 months ago
FWIW that patch looks reasonable to me.

I don't know the answer to Nathan's question.  However the patch seems to make it moot.
Flags: needinfo?(ttromey)
Comment on attachment 8998369 [details]
Bug 1481555: Use lldb's python API to summarise nsAtoms.

Nathan Froyd [:froydnj] has approved the revision.
Attachment #8998369 - Flags: review+

Comment 6

10 months ago
Pushed by dtownsend@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ff3a0784588f
Use lldb's python API to summarise nsAtoms. r=froydnj

Comment 7

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ff3a0784588f
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Assignee: nobody → dtownsend
You need to log in before you can comment on or make changes to this bug.