Closed
Bug 1481571
Opened 5 years ago
Closed 5 years ago
Add Google icon to top_sites.json
Categories
(Firefox :: New Tab Page, enhancement, P1)
Firefox
New Tab Page
Tracking
()
People
(Reporter: rrosario, Assigned: rrosario)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Now that the Google Search shortcut will be possibly shown on first run, we should ship a Google icon like we do for other default Top Sites. We just need to add a PNG to: data/content/tippytop/images/ and add an entry into data/content/tippytop/top_sites.json
Comment 1•5 years ago
|
||
Updated•5 years ago
|
Severity: normal → enhancement
Comment 2•5 years ago
|
||
Commits pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/76fad5075634c839eae920088540bf1dc0b31272 Fix Bug 1481571 - ship a google icon https://github.com/mozilla/activity-stream/commit/c18e53a101683857287461a660b7ed26ae5924e9 Merge pull request #4293 from rlr/bug1481571/google-icon Fix Bug 1481571 - ship a google icon
Updated•5 years ago
|
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Comment 3•5 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/972b3c48c6e9
status-firefox63:
--- → fixed
Target Milestone: --- → Firefox 63
Comment 4•5 years ago
|
||
I have verified this on Windows 10 x64, Arch Linux and Mac 10.13.3 with the latest version of "Firefox Nightly" (63.0a1 - Build ID 20180813220525) installed and I can confirm that there is a "Google" icon displayed for the "Google Search shortcut".
Status: RESOLVED → VERIFIED
Comment 5•5 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/9e752b54a20f425449e1f00bf3adefa903f8051a
status-firefox62:
--- → fixed
Comment 6•5 years ago
|
||
I have verified that the "Google" icon is displayed for the Google search shortcut in the latest Beta (62.0b18 Build ID 20180816151750) on Windows 10, Mac 10.13 and Arch Linux x64.
Updated•4 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•