1481571 - Add Google icon to top_sites.json

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Ricky Rosario [:rrosario, :r1cky]]

Now that the Google Search shortcut will be possibly shown on first run, we should ship a Google icon like we do for other default Top Sites.

We just need to add a PNG to: data/content/tippytop/images/ and add an entry into data/content/tippytop/top_sites.json

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4293

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/76fad5075634c839eae920088540bf1dc0b31272
Fix Bug 1481571 - ship a google icon

https://github.com/mozilla/activity-stream/commit/c18e53a101683857287461a660b7ed26ae5924e9
Merge pull request #4293 from rlr/bug1481571/google-icon

Fix Bug 1481571 - ship a google icon

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/972b3c48c6e9

Comment 4

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this on Windows 10 x64, Arch Linux and Mac 10.13.3 with the latest version of "Firefox Nightly" (63.0a1 - Build ID 20180813220525) installed and I can confirm that there is a "Google" icon displayed for the "Google Search shortcut".

Comment 5

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-beta/rev/9e752b54a20f425449e1f00bf3adefa903f8051a

Comment 6

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the "Google" icon is displayed for the Google search shortcut in the latest Beta (62.0b18 Build ID 20180816151750) on Windows 10, Mac 10.13 and Arch Linux x64.