1481623 - Sync device list shows disconnected iOS device

Status: VERIFIED FIXED

(Firefox :: Sync, defect, P3)

Description

[Kanchan Kumari QA]

Prerequisite:
On iOS I am using Firefox iOS Beta w/ New Send Tab (using Stage server): https://dashboard.buddybuild.com/apps/57bf25c0f096bc01001e21e0/build/5b60ab286c9917000137e0f8

STR:
1. Sign in to sync on multiple devices (Windows, Linux Desktops instances, iOS)pointing to staging server
2. Go to one of Desktop instances(in my case Linux) and disconnect iOS device
3. Sync all devices
 
Expected: iOS device is removed from send tab device list on all Fx instances

Actual: One of Fx instance still shows iOS device in send tab device list (made sure sync is disconnected on iOS)

Please see video here https://svtest2222-gmail.tinytake.com/sf/MjgyMTYxOV84NDcxNTI1

Comment 1

[Mark Hammond [:markh] [:mhammond]]

That implies the device which still lists it did not get a push message telling us about the disconnection. Kanchan:

* are you able to reliably reproduce it?
* can you please verify it is no longer there next time the device starts?
* attach the logs, both from one of the devices which correctly did not show it, and from the one device that did?

Comment 2

[Kanchan Kumari QA]

Attachment: SendTabList.png

(In reply to Mark Hammond [:markh] from comment #1)
> That implies the device which still lists it did not get a push message
> telling us about the disconnection. Kanchan:
> 
> * are you able to reliably reproduce it?
> * can you please verify it is no longer there next time the device starts?
> * attach the logs, both from one of the devices which correctly did not show
> it, and from the one device that did?

I couldn't reliably reproduce this bug but I encountered similar intermittent bug where many times Send tab device on Desktop instance list showed disconnected iOS devices, only difference was that this time all desktop Fx instances displayed the same send device list. 
For ex see attached image. In this list only iPad and one iPhone are connected, rest two iPhone instances are disconnected. You may want to look into bug 1482554

I will keep trying reproducing this bug. In case I encounter this I will attach sync logs here. Thanks!

Comment 3

[Kanchan Kumari QA]

Attachment: Devicedoesn'tshow disconnected device.zip

I was able to reproduce this issue

Build ID 	20180814005228
User Agent 	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:63.0) Gecko/20100101 

Please note device which doesn't show disconnected device has identity.fxaccounts.commands.enabled;false

Device which shows disconnected device has identity.fxaccounts.commands.enabled;true

Comment 4

[Kanchan Kumari QA]

Attachment: device which shows disconnected devices

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Thanks Kanchan,
  It's difficult to work out what is going on there. I'm going to open a bug to improve the logging, but it seems likely that we simply didn't get a push message to tell us about the notification. So long as the device is no longer listed after the browser restarts, I don't think we will take any action here.

Comment 6

[Alex Davis [:adavis]]

I'm just chiming in because my opinion was asked by Julie.

This is low priority because it doesn't prevent any user experience and is intermittent. Also, IIRC, the device list automatically removes inactive devices after a couple of weeks so the problem should resolve itself.

Mark, please link to the bug that aims to improve logging.

Comment 7

[Edouard Oger [:eoger]]

Bug 1507294 may also have improved the situation as we refresh the send-tab list (and filter stale devices) every sync now.

Comment 8

[Mihai Boldan, Desktop QA [:mboldan]]

I'm marking this bug as Verified Fixed since is no longer reproducible on Firefox 64.0b11. It seems that the fix from Bug 1507294 resolved also this issue.
Tests were performed unde Windows 10x64, Ubuntu 18.04x64, macOS 10.13 and iPhone5.