Closed Bug 1481672 Opened Last year Closed Last year

xperf: field names for Microsoft-Windows-TCPIP/TcpDataTransferSend have changed in new Windows versions

Categories

(Testing :: Talos, defect, P1)

Unspecified
Windows
defect

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

References

Details

Attachments

(1 file)

Apparently the field representing the number of bytes was renamed at some point from "NumBytes" to "BytesSent". This causes etlparser.py to fail during analysis of network I/O, since it is attempting to access the field using the original name.
Comment on attachment 8998379 [details] [diff] [review]
Add support for columns named "BytesSent" to etlparser

Review of attachment 8998379 [details] [diff] [review]:
-----------------------------------------------------------------

:aklotz this looks ok, so r+.
Some small nits: for getIndex() function, rename `eventType` param to `eventName`, to have some consistency with the EVENTNAME_INDEX variable.
Also, wouldn't it be safer to use file context managers for code like `data = csv.reader(open(filename, ...)`? Something like:
```
with open(filename, <whatever_flags>) as fileobj:
    data = csv.reader(fileobj, ...)
```
Attachment #8998379 - Flags: review?(igoldan) → review+
(In reply to Ionuț Goldan [:igoldan], Performance Sheriffing from comment #2)
> Comment on attachment 8998379 [details] [diff] [review]
> Add support for columns named "BytesSent" to etlparser
> 
> Also, wouldn't it be safer to use file context managers for code like `data
> = csv.reader(open(filename, ...)`? Something like:
> ```
> with open(filename, <whatever_flags>) as fileobj:
>     data = csv.reader(fileobj, ...)
> ```

That's outside the scope of this bug, but we can file a new one for that if you want.
https://hg.mozilla.org/integration/mozilla-inbound/rev/955619c5ef35574ffff8094beac9f25985e111c9
Bug 1481672: Modify etlparser to try both "NumBytes" and "BytesSent" columns for network I/O events; r=igoldan
https://hg.mozilla.org/integration/mozilla-inbound/rev/d70846fc23060425046e9fe48f24830dde9bdb90
Bug 1481672: Modify etlparser to try both "NumBytes" and "BytesSent" columns for network I/O events; r=igoldan
Summary: xperf: field names for Microsoft-Windows-TCPCP/TcpDataTransferSend have changed in new Windows versions → xperf: field names for Microsoft-Windows-TCPIP/TcpDataTransferSend have changed in new Windows versions
https://hg.mozilla.org/mozilla-central/rev/d70846fc2306
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.