Closed Bug 1481677 Opened 4 years ago Closed 4 years ago
Make in-content search box become fixed when scrolling
52 bytes, text/x-github-pull-request
|Details | Review|
UX Mockups: https://mozilla.invisionapp.com/share/URNEIGMWKB9#/screens Mostly working prototype (verified by UX): https://rlr.github.io/newtab-search-scroll-to-fixed/dist/index.html Some Notes: * The search box is narrower on wide layout now. It doesn't change width between wide and narrow layouts anymore. * There is now more space around the search box. ** On shorter windows (<700px), the space is less than on taller windows * After scrolling up a little, the search box becomes fixed to the top like a header for the page. ** On shorter windows (<700px), we just keep scrolling. We don't convert it to fixed.
Commits pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/2a29885ab983f37316fc4f665c03e71df9e4688d Fix Bug 1481677 - persistent/stable search (aka fixed position search bar) https://github.com/mozilla/activity-stream/commit/0346c12b301282fb1849659880cc31e66956cc77 Merge pull request #4298 from rlr/bug1481677/search-scroll-fixed Fix Bug 1481677 - persistent/stable search (aka fixed position search bar)
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
I have verified this on Windows 10 x64, Arch Linux and Mac 10.13.3 with the latest version of "Firefox Nightly" (63.0a1 - Build ID 20180813220525) installed and I can confirm that when scrolling the "Search Box", it becomes fixed to the top of the page and becomes smaller.
I have verified that the Search Bar becomes fixed when the page is scrolled in the latest Beta (62.0b18 Build ID 20180816151750) as presented in the mock-ups, on Windows 10, Mac 10.13 and Arch Linux x64.
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.