Remove .autocomplete-history-popup styling

RESOLVED FIXED in Firefox 63

Status

()

enhancement
P3
normal
RESOLVED FIXED
10 months ago
9 months ago

People

(Reporter: dao, Assigned: sahilbhosale63, Mentored)

Tracking

({good-first-bug})

Trunk
mozilla63
Points:
---

Firefox Tracking Flags

(firefox63 fixed)

Details

(Whiteboard: [lang=css])

Attachments

(1 attachment)

Reporter

Description

10 months ago
This class appears to be obsolete and unused, so let's remove it from these stylesheets:

https://searchfox.org/mozilla-central/search?q=autocomplete-history-popup&case=true&path=
Reporter

Updated

10 months ago
Priority: -- → P3

Comment 1

10 months ago
can i work on this issue?. Can i find the source code on Github too? Thanks in advance :)
Flags: needinfo?(dao+bmo)
Reporter

Comment 2

10 months ago
(In reply to Hritvi Bhandari from comment #1)
> can i work on this issue?. Can i find the source code on Github too? Thanks
> in advance :)

Here: https://github.com/mozilla/gecko-dev
Flags: needinfo?(dao+bmo)

Comment 3

10 months ago
I wasn't aware that we can PR these bugs on github also.

Comment 4

10 months ago
I don't suppose that we can add a PR on the github...and i am still unable to setup mercurian on my PC. I would update it as soon as I am able to solve the issues with my local setup. Till then if some anyone else want to take up this than he/she is truly welcomed. Sorry for the inconvenience caused :)

Updated

10 months ago
Assignee: nobody → 1991manish.kumar

Comment 5

10 months ago
Dao::

Can we submit changes using PR on github?
https://searchfox.org/mozilla-central/search?q=autocomplete-history-popup&case=true&path


but on one PR, they mention that for gecko-dev, we can not use PR-
https://github.com/mozilla/gecko-dev/pull/137
Flags: needinfo?(dao+bmo)
Reporter

Comment 6

9 months ago
No, you'd still have to attach the patch here.

Manish, you're still assigned to two other bugs that I'm mentoring. Please leave some good first bugs for others.
Assignee: 1991manish.kumar → nobody
Flags: needinfo?(dao+bmo)
Assignee

Comment 7

9 months ago
Can I work on this issue??
Reporter

Comment 8

9 months ago
(In reply to Sahil Bhosale from comment #7)
> Can I work on this issue??

Yep.
Assignee

Comment 9

9 months ago
Posted patch my.patchSplinter Review
Remove .autocomplete-history-popup styling.
Attachment #8999895 - Flags: review?(dao+bmo)
Reporter

Comment 10

9 months ago
Comment on attachment 8999895 [details] [diff] [review]
my.patch

Perfect, thanks!
Attachment #8999895 - Flags: review?(dao+bmo) → review+
Reporter

Updated

9 months ago
Assignee: nobody → sahilbhosale63
Keywords: checkin-needed

Comment 11

9 months ago
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2070b60e32cd
Remove .autocomplete-history-popup styling. r=dao
Keywords: checkin-needed

Comment 12

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2070b60e32cd
Status: NEW → RESOLVED
Last Resolved: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.