Closed Bug 1481724 Opened 2 years ago Closed 2 years ago

Remove .autocomplete-history-popup styling

Categories

(Toolkit :: Themes, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: dao, Assigned: sahilbhosale63, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=css])

Attachments

(1 file)

This class appears to be obsolete and unused, so let's remove it from these stylesheets:

https://searchfox.org/mozilla-central/search?q=autocomplete-history-popup&case=true&path=
Priority: -- → P3
can i work on this issue?. Can i find the source code on Github too? Thanks in advance :)
Flags: needinfo?(dao+bmo)
(In reply to Hritvi Bhandari from comment #1)
> can i work on this issue?. Can i find the source code on Github too? Thanks
> in advance :)

Here: https://github.com/mozilla/gecko-dev
Flags: needinfo?(dao+bmo)
I wasn't aware that we can PR these bugs on github also.
I don't suppose that we can add a PR on the github...and i am still unable to setup mercurian on my PC. I would update it as soon as I am able to solve the issues with my local setup. Till then if some anyone else want to take up this than he/she is truly welcomed. Sorry for the inconvenience caused :)
Assignee: nobody → 1991manish.kumar
Dao::

Can we submit changes using PR on github?
https://searchfox.org/mozilla-central/search?q=autocomplete-history-popup&case=true&path


but on one PR, they mention that for gecko-dev, we can not use PR-
https://github.com/mozilla/gecko-dev/pull/137
Flags: needinfo?(dao+bmo)
No, you'd still have to attach the patch here.

Manish, you're still assigned to two other bugs that I'm mentoring. Please leave some good first bugs for others.
Assignee: 1991manish.kumar → nobody
Flags: needinfo?(dao+bmo)
Can I work on this issue??
(In reply to Sahil Bhosale from comment #7)
> Can I work on this issue??

Yep.
Attached patch my.patchSplinter Review
Remove .autocomplete-history-popup styling.
Attachment #8999895 - Flags: review?(dao+bmo)
Comment on attachment 8999895 [details] [diff] [review]
my.patch

Perfect, thanks!
Attachment #8999895 - Flags: review?(dao+bmo) → review+
Assignee: nobody → sahilbhosale63
Keywords: checkin-needed
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2070b60e32cd
Remove .autocomplete-history-popup styling. r=dao
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2070b60e32cd
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.