1481754 - Use inheritance for menu fonts

Status: RESOLVED FIXED

(Toolkit :: Themes, enhancement, P3)

Description

[Dão Gottwald [:dao]]

Rather than setting a font on every single menuitem and friends, we should set it on the parent and let it be inherited (font is inherited by default just like color).

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Comment 2

[Dão Gottwald [:dao]]

https://screenshots.mattn.ca/compare/?oldProject=try&oldRev=597f8d9971e942d016974cc232d096bf244dbe6e&newProject=try&newRev=33211671d1d0dc4aebf7f6cb56b6134890c2e8b4

Comment 3

[Mark Striemer [:mstriemer]]

Comment on attachment 8998735 [details] [diff] [review]
patch

Review of attachment 8998735 [details] [diff] [review]:
-----------------------------------------------------------------

Poked around and didn't see any regressions. Looks like a nice cleanup to me.

::: toolkit/themes/linux/global/menu.css
@@ +71,5 @@
>    color: -moz-menubarhovertext;
>    background-color: -moz-menuhover;
>  }
> +
> +menuitem[default="true"],

This rule appears to be in windows, linux and osx. Can it be moved to shared instead?

Comment 4

[Dão Gottwald [:dao]]

(In reply to Mark Striemer [:mstriemer] from comment #3)
> Comment on attachment 8998735 [details] [diff] [review]
> patch
> 
> Review of attachment 8998735 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Poked around and didn't see any regressions. Looks like a nice cleanup to me.
> 
> ::: toolkit/themes/linux/global/menu.css
> @@ +71,5 @@
> >    color: -moz-menubarhovertext;
> >    background-color: -moz-menuhover;
> >  }
> > +
> > +menuitem[default="true"],
> 
> This rule appears to be in windows, linux and osx. Can it be moved to shared
> instead?

I don't think there's a shared stylesheet where this would fit and I wouldn't create one for just one rule. However, I can look into whether there's more to share from menu.css in a followup.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c63d5a13deb
Use inheritance for menu fonts. r=mstriemer

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/1c63d5a13deb

Comment 7

[Tim Nguyen :ntim]

Attachment: Before - Select font-size on MacOS

Comment 8

[Tim Nguyen :ntim]

Attachment: After - Select font-size on MacOS

This seems to have slightly increased the font-size of <select> options on macOS.

Comment 9

[Stefan [:stefanh]]

It looks like https://hg.mozilla.org/mozilla-central/diff/1c63d5a13deb/toolkit/themes/osx/global/menu.css#l1.98 and https://hg.mozilla.org/mozilla-central/diff/1c63d5a13deb/toolkit/themes/osx/global/menu.css#l1.77 made menuitems in menulists use -moz-pull-down-menu. The reason for the 'inherit' was to use the the same font as the menulist itself (which normally inherit the font from the parent). You can see the effect in the clear history menulist.