Closed Bug 1481781 Opened 2 years ago Closed 2 years ago

Ensure specified_is_copy returns exactly the right result for all properties

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

Details

Attachments

(1 file)

I realized that there are multiple properties which have Copy specified value but specified_is_copy doesn't return true for them. This is because we never really check that those are not Copy.

This usually happens when we move a keyword from mako to enum in values mod.

In this bug I intend to add a check for that so that we have checks either way, ensuring specified_is_copy always returns the correct result.
Comment on attachment 8998491 [details]
Bug 1481781 - Add check for non-Copy specified value to ensure specified_is_copy always returns the right result. r?emilio

Emilio Cobos Álvarez (:emilio) has approved the revision.
Attachment #8998491 - Flags: review+
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4fabd8dc76ee
Add check for non-Copy specified value to ensure specified_is_copy always returns the right result. r=emilio
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cea8cf3f6abe
followup - Fixup order in properties-db.js on a CLOSED TREE.
https://hg.mozilla.org/mozilla-central/rev/4fabd8dc76ee
https://hg.mozilla.org/mozilla-central/rev/cea8cf3f6abe
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.