46 bytes, text/x-phabricator-request
|Details | Review|
The CSS WG just resolved on https://github.com/w3c/csswg-drafts/issues/2988 to change the meaning of the 2-value overflow syntax. We're the only engine that implements; we should switch to match this resolution (assuming we did it right in the first place, at least).
Assignee: nobody → dbaron
Status: NEW → ASSIGNED
Comment on attachment 8999043 [details] Bug 1481866: Swap order of values in 'overflow' shorthand property. r=emilio Emilio Cobos Álvarez (:emilio) has approved the revision.
Attachment #8999043 - Flags: review+
Attachment #8999043 - Attachment description: Bug 1481866: Swap order of values in 'overflow' shorthand property. → Bug 1481866: Swap order of values in 'overflow' shorthand property. r=emilio
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/a377edbfae93 Swap order of values in 'overflow' shorthand property. r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/12393 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Upstream PR merged
This isn't quite right. The CSSWG's resolution is not to change from x/y to y/x, but from x/y to block/inline. In other words, not only swap the order, but also tie to logical rather than physical directions.
(In reply to Florian Rivoal from comment #10) > This isn't quite right. The CSSWG's resolution is not to change from x/y to > y/x, but from x/y to block/inline. In other words, not only swap the order, > but also tie to logical rather than physical directions. That is a very different (and breaking) change... So, for example, you'd make code that sets overflow, then reads out overflow-x / overflow-y not work anymore: document.body.style.overflow = "hidden"; document.body.style.overflowX // "" David, what should we do about this?
8 months ago
Posted the site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2018/overflow-shorthand-syntax-has-been-updated-to-swap-2-values/
I have updated the documentation for this change at https://developer.mozilla.org/en-US/docs/Web/CSS/overflow A review of that would be appreciated.
I think we should back this out, given blink is going to ship x, then y, and we don't really have the infrastructure to implement the behavior that the WG really proposes, which involves implementing two new overflow logical properties, and making shorthands expand to different longhands depending of the syntax of the shorthand.
Okay, I’ve updated the site compatibility note to mark it reverted.
Reverted in docs as well.
You need to log in before you can comment on or make changes to this bug.