Closed
Bug 1481869
Opened 6 years ago
Closed 6 years ago
Correct in-content reporting payload
Categories
(Firefox :: Search, defect, P1)
Firefox
Search
Tracking
()
VERIFIED
FIXED
Firefox 63
People
(Reporter: mkaply, Assigned: mkaply)
Details
Attachments
(1 file)
46 bytes,
text/x-phabricator-request
|
Dolske
:
review+
lizzard
:
approval-mozilla-beta+
|
Details | Review |
I used a period when I was supposed to use a colon for tracking the in-content searches.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Comment 1•6 years ago
|
||
What's the impact of this bug on 61?
Assignee | ||
Comment 2•6 years ago
|
||
> What's the impact of this bug on 61?
Data team will just have to temporarily use a different schema for 61. I've already been in contact with them.
No data loss.
Assignee | ||
Comment 3•6 years ago
|
||
Comment 4•6 years ago
|
||
Comment on attachment 8999269 [details] Bug 1481869 - Correct in-content reporting payload Justin Dolske [:Dolske] has approved the revision.
Attachment #8999269 -
Flags: review+
Pushed by mozilla@kaply.com: https://hg.mozilla.org/integration/autoland/rev/f5748d54bf4b Correct in-content reporting payload r=Dolske
Assignee | ||
Comment 6•6 years ago
|
||
Comment on attachment 8999269 [details] Bug 1481869 - Correct in-content reporting payload Approval Request Comment [Feature/Bug causing the regression]: I typoed on 1475571 [User impact if declined]: None [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: No [Needs manual test from QE? If yes, steps to reproduce]: Yes. documented in bug 1475571 [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: Simple character change. [String changes made/needed]:
Attachment #8999269 -
Flags: approval-mozilla-beta?
Updated•6 years ago
|
Priority: -- → P1
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f5748d54bf4b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Comment 8•6 years ago
|
||
Comment on attachment 8999269 [details] Bug 1481869 - Correct in-content reporting payload Typo fix, let's uplift for beta 17.
Attachment #8999269 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•6 years ago
|
QA Contact: anca.soncutean
Comment 9•6 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/26da3a2d48f9
status-firefox62:
--- → fixed
Updated•6 years ago
|
Flags: qe-verify+
Comment 10•6 years ago
|
||
The typo problem is fixed indeed on Firefox 62.0b17 on Ubuntu 16.04 x64, macOS 10.13 and Windows 10 x64. Just a note here, now, after performing a search in the url bar, the google.in-content:sap:firefox-b-ab inside the histogram is displayed first, google.in-content:organic:none on its right (on the previous beta, google.in-content.organic:none remained on the first position). Is this changing position relevant in any way?
Flags: needinfo?(mozilla)
Assignee | ||
Comment 11•6 years ago
|
||
Nope, position isn't relevant. Thanks for asking.
Flags: needinfo?(mozilla)
Comment 12•6 years ago
|
||
Verified this also, on Nightly 63.0a1 (20180815225731) across platforms. Based on comments 10-11, I will mark this bug as verified.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•