Closed Bug 1481904 Opened Last year Closed Last year

[wpt-sync] Sync PR 12358 - [IntersectionObserver] Fix initial notifications for non-zero threshold

Categories

(Core :: Layout, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 12358 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12358
Details from upstream follow.

Stefan Zager <szager@chromium.org> wrote:
>  [IntersectionObserver] Fix initial notifications for non-zero threshold
>  
>  When a target is first observed, last_threshold_index_ is set to a
>  sentinel value (0x1fffffff), to ensure that an initial notification
>  will be sent on the next frame. For that notification, if the target
>  is intersecting, but the intersection ratio is less than the smallest
>  threshold set on the observer, then the isVisible field of the
>  notification should be false.
>  
>  Also, for IOv2, the isVisible field should always be false -- and
>  skip the expensive hit test -- if the intersection ratio is less
>  than the smallest threshold set on the observer.
>  
>  BUG=847623,827639
>  R=chrishtr@chromium.org
>  
>  Change-Id: I518ff97a23afd92a82c4d01d9280d57ffb0c9ae2
>  Reviewed-on: https://chromium-review.googlesource.com/1167884
>  WPT-Export-Revision: 25fba2fda77f64b2af79255fbb030f9c7024b087
Component: web-platform-tests → Layout
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 1 tests and 3 subtests
OK     : 1
PASS   : 2
FAIL   : 1

New tests that have failures or other problems:
/intersection-observer/initial-observation-with-threshold.html
    First rAF: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fad7f71861a3
[wpt PR 12358] - [IntersectionObserver] Fix initial notifications for non-zero threshold, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/b2ecac097a34
[wpt PR 12358] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/fad7f71861a3
https://hg.mozilla.org/mozilla-central/rev/b2ecac097a34
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.