Multiple tabs displaying same image can forget dirty rect updates

RESOLVED FIXED in Firefox 63

Status

()

enhancement
P1
normal
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: aosmond, Assigned: aosmond)

Tracking

Trunk
mozilla63
Points:
---

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

10 months ago
We only use the dirty rect for a shared surface properly for the first WebRenderLayerManager requiring a resource update. Other instances using the same image may end up not updating at all. This will probably only be visible for really large, slow to download/decode images, but I could see it happening where you click a downscaled image and it opens a new tab to view the full sized image (but they point to the same resource).
Assignee

Updated

10 months ago
Assignee: nobody → aosmond
Status: NEW → ASSIGNED
Priority: -- → P1

Updated

10 months ago
Attachment #8998625 - Flags: review?(nical.bugzilla) → review+

Comment 2

10 months ago
Pushed by aosmond@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0386ff1e9956
Store a shared surface's dirty rect update if we cannot process it immediately. r=nical

Comment 3

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0386ff1e9956
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.