Closed
Bug 1481933
Opened 6 years ago
Closed 6 years ago
Multiple tabs displaying same image can forget dirty rect updates
Categories
(Core :: Graphics: WebRender, enhancement, P1)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: aosmond, Assigned: aosmond)
Details
Attachments
(1 file)
|
4.36 KB,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
We only use the dirty rect for a shared surface properly for the first WebRenderLayerManager requiring a resource update. Other instances using the same image may end up not updating at all. This will probably only be visible for really large, slow to download/decode images, but I could see it happening where you click a downscaled image and it opens a new tab to view the full sized image (but they point to the same resource).
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → aosmond
Status: NEW → ASSIGNED
Priority: -- → P1
|
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8998625 -
Flags: review?(nical.bugzilla)
|
||
Updated•6 years ago
|
Attachment #8998625 -
Flags: review?(nical.bugzilla) → review+
Pushed by aosmond@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0386ff1e9956 Store a shared surface's dirty rect update if we cannot process it immediately. r=nical
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0386ff1e9956
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•