Closed Bug 1481933 Opened 2 years ago Closed 2 years ago

Multiple tabs displaying same image can forget dirty rect updates

Categories

(Core :: Graphics: WebRender, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: aosmond, Assigned: aosmond)

Details

Attachments

(1 file)

We only use the dirty rect for a shared surface properly for the first WebRenderLayerManager requiring a resource update. Other instances using the same image may end up not updating at all. This will probably only be visible for really large, slow to download/decode images, but I could see it happening where you click a downscaled image and it opens a new tab to view the full sized image (but they point to the same resource).
Assignee: nobody → aosmond
Status: NEW → ASSIGNED
Priority: -- → P1
Attachment #8998625 - Flags: review?(nical.bugzilla) → review+
Pushed by aosmond@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0386ff1e9956
Store a shared surface's dirty rect update if we cannot process it immediately. r=nical
https://hg.mozilla.org/mozilla-central/rev/0386ff1e9956
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.