1481946 - [Search Engine policies] Changes performed inside the URLTemplate are not applied

Status: VERIFIED FIXED

(Firefox :: Enterprise Policies, defect, P5)

Description

[Emil Ghitta, QA [:emilghitta]]

[Affected versions]:
Firefox 63.0a1 (BuildId:20180808100114).
Firefox 62.0b15 (BuildId:20180806191531).

[Affected platforms]:
Windows 10 64bit.

[Preconditions]
Add the following information inside the JSON:
{
 "policies": {
    "SearchEngines": {
        "Add": [
{
      "Name": "MozSearcsahe",
      "URLTemplate": "https://www.youtube.com"
}
],
      "Default": "MozSearcsahe"
}
}
}

[Steps to reproduce]:
1. Launch Firefox.
2. Search for something inside the URL bar.
3. Modify the JSON and add the https://www.example.com inside the URLTemplate field.
4. Restart Firefox.
5. Search for something inside the URL bar again.

[Expected result]:
The https://www.example.com is displayed.

[Actual result]:
The https://www.youtube.com is displayed.

Comment 1

[:Felipe Gomes (needinfo for replies!)]

We could fix this with workarounds on the policies code level, but my preferred solution for this is bug 1445134

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Bug 1481946 - Allow policy search engines to be updated. r?Standard8!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a189dfd7054
Allow policy search engines to be updated. r=Standard8

Comment 4

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/8a189dfd7054

Comment 5

[Mike Kaply [:mkaply]]

Comment on attachment 9250182 [details]
Bug 1481946 - Allow policy search engines to be updated. r?Standard8!

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Policy only, search policy is ESR only anyway.
• User impact if declined: Search engine policy changes don't propagate
• Fix Landed on Version: 96
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Automated test, policy only.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9250182 [details]
Bug 1481946 - Allow policy search engines to be updated. r?Standard8!

Approved for 91.5esr.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/f8cf5e64457d

Comment 8

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 91.5.0esr (BuildId:20220105212146) on Windows 10 64bit.

The updates made inside the JSON file (while Firefox is running) are successfully applied after a browser restart.

(Note: Hence this is an ESR only policy, the status for 96 can't transition to verified).