148195 - remove session-logout code from mailnews

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Stephen P. Morse]

As a result of the patch in bug 98673, the session-logout signal is no longer 
being issued.  The code for handling that signal should be removed.

This occurs in the following place in mailnews

/mailnews/base/src/nsMsgAccountManager.cpp, line 192 -- 
observerService->AddObserver(this, "session-logout", PR_TRUE);
/mailnews/base/src/nsMsgAccountManager.cpp, line 261 -- if 
(!nsCRT::strcmp(aTopic, "session-logout"))

Comment 1

[(not reading, please use [e-mail] instead)]

mass re-assign.

Comment 2

[David :Bienvenu]

taking

Comment 3

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) <nsMsgAccountManager.cpp>

Comment 4

[Serge Gautherie (:sgautherie)]

Attachment: (Av1a) <nsMsgAccountManager.cpp> [Checkin: Comment 7]

Comment 5

[David :Bienvenu]

Comment on attachment 325990 [details] [diff] [review]
(Av1a) <nsMsgAccountManager.cpp>
[Checkin: Comment 7]

looks like there's still some necko and nss code that pays attention to this notification...but no one sending it.

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to comment #5)

Yes: bug 148192 and bug 148194.

Comment 7

[Mark Banner (:standard8)]

Checking in mailnews/base/src/nsMsgAccountManager.cpp;
/cvsroot/mozilla/mailnews/base/src/nsMsgAccountManager.cpp,v  <--  nsMsgAccountManager.cpp
new revision: 1.338; previous revision: 1.337
done

Comment 8

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1-18B) <nsMsgAccountManager.*>

1.8(.1) branch port of Av1a patch.

Comment 9

[Phil Ringnalda (:philor)]

> 1.8(.1) branch port of Av1a patch.

If you land that on the branch, what happens to an extension which thinks that by firing session-logout, it will get the user logged out of any active mail sessions?

Comment 10

[David :Bienvenu]

why would we land this on the branch? Isn't it just code cleanup?

Comment 11

[Serge Gautherie (:sgautherie)]

(In reply to comment #9)

Such an extension would be "broken", obviously.

(In reply to comment #10)
> why would we land this on the branch? Isn't it just code cleanup?

I submitted this patch because bug 98673 landed years ago;
but, if you think we should leave this code on the branch, that would be fine with me.

Yes: simple "dead" code removal.

Comment 12

[David :Bienvenu]

Comment on attachment 326581 [details] [diff] [review]
(Bv1-18B) <nsMsgAccountManager.*>

yeah, I'm happy leaving the branch this way.