Closed Bug 1481958 Opened Last year Closed Last year

Add binary version checking to TestNativeNt

Categories

(Firefox :: General, enhancement, P1)

Unspecified
Windows
enhancement

Tracking

()

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

References

(Blocks 1 open bug)

Details

(Whiteboard: inj+)

Attachments

(1 file, 2 obsolete files)

I want to ensure that we don't break anything there.
We also need to add a manifest so that GetVersionEx works as expected.
Attachment #8998925 - Flags: review?(mhowell)
Comment on attachment 8998925 [details] [diff] [review]
Add check that kernel32's major and minor version number match the system version

I'm going to cancel this so I can improve this test. We can do better.
Attachment #8998925 - Flags: review?(mhowell)
No longer depends on: 1481956
This patch checks our native NT version detection against the actual version APIs.
Attachment #8998925 - Attachment is obsolete: true
Attachment #8998948 - Flags: review?(mhowell)
Removing a stray include
Attachment #8998948 - Attachment is obsolete: true
Attachment #8998948 - Flags: review?(mhowell)
Attachment #8998955 - Flags: review?(mhowell)
Attachment #8998955 - Flags: review?(mhowell) → review+
https://hg.mozilla.org/mozilla-central/rev/64c7e3b34869
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.