Closed Bug 1481983 Opened Last year Closed Last year

Don't mix || and && in ImageBridgeChild.cpp

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

References

Details

(Whiteboard: gfx-noted)

Attachments

(1 file)

46 bytes, text/x-phabricator-request
sotaro
: review+
Details | Review
clang-cl warns about this. Technically this behaves as if && happens before ||, but no one should need to remember this.

Instead of wrapping this in parens, it's easier to hoist the common case out of the ifdefs. (as well as the variable declaration, which should strongly prefer to be outside ifdefs)
Attached file Don't mix && and ||.
Comment on attachment 8998692 [details]
Don't mix && and ||.

Sotaro Ikeda [:sotaro] has approved the revision.
Attachment #8998692 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/beb04e83301f
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.