Closed Bug 1481983 Opened Last year Closed Last year
Don't mix || and && in Image
Bridge Child .cpp
clang-cl warns about this. Technically this behaves as if && happens before ||, but no one should need to remember this. Instead of wrapping this in parens, it's easier to hoist the common case out of the ifdefs. (as well as the variable declaration, which should strongly prefer to be outside ifdefs)
Comment on attachment 8998692 [details] Don't mix && and ||. Sotaro Ikeda [:sotaro] has approved the revision.
Attachment #8998692 - Flags: review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/beb04e83301f Don't mix && and ||. r=sotaro
You need to log in before you can comment on or make changes to this bug.