Closed Bug 1481989 Opened Last year Closed Last year

Copy 32-bits libraries from gcc to clang

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(2 files)

Moving this out of bug 1480631.
We only enable libstdc++ compat on Android for the host parts, and
in practice, the target part has it not enabled at the moment because
libstdc++ can't be found. But making the clang toolchain capable of
building for x86 changes the deal for Android x86.
Attachment #8998697 - Flags: review?(core-build-config-reviews)
This was r+ by froydnj in bug 1480631.
Attachment #8998698 - Flags: review+
Comment on attachment 8998697 [details] [diff] [review]
Don't try to enable libstdc++ compat on Android

Review of attachment 8998697 [details] [diff] [review]:
-----------------------------------------------------------------

Do we really have to have it for the host parts, or could we just remove the necessary bits from the mozconfig entirely?
Attachment #8998697 - Flags: review?(core-build-config-reviews) → review+
IIRC we package some host binaries that need to run on e.g. Ubuntu 16.04, and they won't run without stdc++compat. If we don't do that, then yes, we could just set LD_LIBRARY_PATH and be done with stdc++compat on android builds.
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8e81d19d476
Don't try to enable libstdc++ compat on Android. r=froydnj
https://hg.mozilla.org/integration/mozilla-inbound/rev/45b401d8443f
Copy 32-bits libraries from gcc to clang. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/c8e81d19d476
https://hg.mozilla.org/mozilla-central/rev/45b401d8443f
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.