1482012 - Split HTMLEditor::Paste() for internal use

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Got a cold so that using sick leaves)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ea97ae3696e224cd36e27befd1b5f4238071e67

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Got a cold so that using sick leaves)]

Attachment: Bug 1482012 - part 1: Create HTMLEditor::PasteInternal() for internal use

HTMLEditor::Paste() is an override of nsIEditor.  So, it's virtual and public.
We should use protected method for internal use and should make it non-virtual
if possible.  This patch creates PasteInternal() which is a protected
non-virtual method.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Got a cold so that using sick leaves)]

Attachment: Bug 1482012 - part 2: Create TextEditor::PasteAsAction() as non-virtual method for outer C++ code

User may paste a lot with pressing Accel+V for a while (i.e., with auto repeat).
So, calling nsIEditor::Paste() may be in a hot path and we can now make
non-virtual public method with AsHTMLEditor().

Comment 4

[Makoto Kato [:m_kato]]

Comment on attachment 8998759 [details]
Bug 1482012 - part 1: Create HTMLEditor::PasteInternal() for internal use

Makoto Kato [:m_kato] has approved the revision.

Comment 5

[Makoto Kato [:m_kato]]

Comment on attachment 8998760 [details]
Bug 1482012 - part 2: Create TextEditor::PasteAsAction() as non-virtual method for outer C++ code

Makoto Kato [:m_kato] has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b11bd5b080a2
part 1: Create HTMLEditor::PasteInternal() for internal use r=m_kato

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a415ada9fdae
part 2: Create TextEditor::PasteAsAction() as non-virtual method for outer C++ code r=m_kato

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/b11bd5b080a2
https://hg.mozilla.org/mozilla-central/rev/a415ada9fdae