1482016 - Split HTMLEditor::SelectElement() for internal use

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1482016 - part 1: Create HTMLEditor::SelectContentInternal() for internal use of HTMLEditor::SelectElement()

For making it possible HTMLEditor::SelectElement() to distinguish if it's
called by outer class or editor itself, this patch creates
HTMLEditor::SelectContentInternal().

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=47562c0f89331b3172f74ebc4462d7e562e9dc53

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1482016 - part 0: Add automated tests for nsIHTMLEditor.selectElement()

Comment 4

[Makoto Kato [:m_kato]]

Comment on attachment 8998801 [details]
Bug 1482016 - part 1: Create HTMLEditor::SelectContentInternal() for internal use of HTMLEditor::SelectElement()

Makoto Kato [:m_kato] has approved the revision.

Comment 5

[Makoto Kato [:m_kato]]

Comment on attachment 8999498 [details]
Bug 1482016 - part 0: Add automated tests for nsIHTMLEditor.selectElement()

Makoto Kato [:m_kato] has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/302ce3cdb98f
part 0: Add automated tests for nsIHTMLEditor.selectElement() r=m_kato

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec2b796f1af2
part 1: Create HTMLEditor::SelectContentInternal() for internal use of HTMLEditor::SelectElement() r=m_kato

Comment 8

[Tiberius Oros[:tiberius_oros]]

Backed out changeset ec2b796f1af2 (bug 1482016) for build bustages on builds/worker/workspace/build/src/editor/libeditor/HTMLTableEditor

Backout: 
https://hg.mozilla.org/integration/autoland/rev/b9c875be605ea87103ccd549954a59543fbf48de

Push with the failures: 
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=ec2b796f1af29470e3a96873df7fb8dcf805edb3

Failure log file:
https://treeherder.mozilla.org/logviewer.html#?job_id=193800730&repo=autoland&lineNumber=20948

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Wow, odd... Why did it green on tryserver??

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Ah... opt only...

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=331bfb538c8245908931a36523a9a2f8086b8b67

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/419fd4edef4f
part 1: Create HTMLEditor::SelectContentInternal() for internal use of HTMLEditor::SelectElement() r=m_kato

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/302ce3cdb98f
https://hg.mozilla.org/mozilla-central/rev/419fd4edef4f

Comment 14

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/55313d9fd453
Backed out changeset 302ce3cdb98f for turning bug 1480702 into permafail. a=backout

Comment 15

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/8546719c58dc
Backed out changeset 419fd4edef4f for turning Bug 1480702 into permafail. a=backout

Comment 16

[Cosmin Sabou [:CosminS]]

Backed out for turning Bug 1480702 into permafail. I don't know how these two are related but looking at the below retriggers it shows clearly this is where it started. 

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-searchStr=Android%204.3%20API16%2B%20debug%20Mochitests%20test-android-em-4.3-arm7-api-16%2Fdebug-mochitest-36%20M(36)&fromchange=597222dce884518ce020cd7a1552d0b571a158de&tochange=fd9dd6df3ae7acc647af581a8e0db4e6d43aa6b9&selectedJob=193959051

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=193959051&repo=autoland&lineNumber=1556

Backout links: 
https://hg.mozilla.org/mozilla-central/rev/55313d9fd453e37f3a34b9f9c9b714d4ccbb320d
https://hg.mozilla.org/mozilla-central/rev/8546719c58dc2310bdafb81fd64a6295c59cd10e


[task 2018-08-14T21:27:10.656Z] 21:27:10     INFO -  131 INFO TEST-PASS | dom/tests/mochitest/fetch/test_request.html | NestedWorker: true: Used Request cannot be passed to new Request
[task 2018-08-14T21:27:10.656Z] 21:27:10     INFO -  Buffered messages finished
[task 2018-08-14T21:27:10.657Z] 21:27:10     INFO -  132 INFO TEST-UNEXPECTED-FAIL | dom/tests/mochitest/fetch/test_request.html | ServiceWorker: worker failed to import test_request.js; error: Failed to load worker script at test_request.js (nsresult = 0x8053000b)
[task 2018-08-14T21:27:10.657Z] 21:27:10     INFO -      onMessage@dom/tests/mochitest/fetch/fetch_test_framework.js:93:13
[task 2018-08-14T21:27:10.657Z] 21:27:10     INFO -  133 INFO TEST-OK | dom/tests/mochitest/fetch/test_request.html | took 34412ms

Comment 17

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Hmm, if so, it's really odd since my patches changed HTMLEditor which is created only when a document is in designMode or has one or more elements which have contenteditable attribute. Those files do not create HTMLEditor instance:
https://searchfox.org/mozilla-central/source/dom/tests/mochitest/fetch/test_request.html
https://searchfox.org/mozilla-central/source/dom/tests/mochitest/fetch/fetch_test_framework.js
https://searchfox.org/mozilla-central/source/dom/tests/mochitest/fetch/message_receiver.html

Comment 18

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Oh, and according to the treehearder, adding the new automated test caused the failure???

Comment 19

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

In tryserver, I didn't see the failure...
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ce4b672ad880367e892e7cd9cdfceffd02434f6b
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5778cad3a3fcc54a76e52c480f3ab387319ee080
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0ceae21dfad91a4a98d1942f25cc9f09324afe2b

Comment 20

[Cosmin Sabou [:CosminS]]

I cannot explain it either but backing out this bug turned the test green again: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=55313d9fd453e37f3a34b9f9c9b714d4ccbb320d&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=pending&filter-resultStatus=running&filter-resultStatus=success&filter-searchStr=android%204.3%20api16%20%20debug%20mochitests%20test-android-em-4.3-arm7-api-16%2Fdebug-mochitest-36%20m(36)&selectedJob=194005185 
Until then it all orange.

Comment 21

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Yeah, I'll reland them with disabling the new test only on debug Android.

Comment 22

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=422c62e800d022141ec1211b6a25e89424aadad6

Comment 23

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=811fc2884be85b38da37f30f678d6b73d4b40072

Comment 24

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba9768e2405f63868837b7f936580a67e0ad79f9

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6f93da48017
part 0: Add automated tests for nsIHTMLEditor.selectElement() r=m_kato

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0c40b74e2b9
part 1: Create HTMLEditor::SelectContentInternal() for internal use of HTMLEditor::SelectElement() r=m_kato

Comment 27

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/e6f93da48017
https://hg.mozilla.org/mozilla-central/rev/c0c40b74e2b9