Closed Bug 1482016 Opened Last year Closed Last year

Split HTMLEditor::SelectElement() for internal use

Categories

(Core :: DOM: Editor, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

No description provided.
For making it possible HTMLEditor::SelectElement() to distinguish if it's
called by outer class or editor itself, this patch creates
HTMLEditor::SelectContentInternal().
Attachment #8998801 - Attachment description: Bug 1482016 - Create HTMLEditor::SelectContentInternal() for internal use of HTMLEditor::SelectElement() → Bug 1482016 - part 1: Create HTMLEditor::SelectContentInternal() for internal use of HTMLEditor::SelectElement()
Comment on attachment 8998801 [details]
Bug 1482016 - part 1: Create HTMLEditor::SelectContentInternal() for internal use of HTMLEditor::SelectElement()

Makoto Kato [:m_kato] has approved the revision.
Attachment #8998801 - Flags: review+
Comment on attachment 8999498 [details]
Bug 1482016 - part 0: Add automated tests for nsIHTMLEditor.selectElement()

Makoto Kato [:m_kato] has approved the revision.
Attachment #8999498 - Flags: review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/302ce3cdb98f
part 0: Add automated tests for nsIHTMLEditor.selectElement() r=m_kato
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/ec2b796f1af2
part 1: Create HTMLEditor::SelectContentInternal() for internal use of HTMLEditor::SelectElement() r=m_kato
Wow, odd... Why did it green on tryserver??
Flags: needinfo?(masayuki)
Ah... opt only...
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/419fd4edef4f
part 1: Create HTMLEditor::SelectContentInternal() for internal use of HTMLEditor::SelectElement() r=m_kato
Status: ASSIGNED → RESOLVED
Closed: Last year
Keywords: leave-open
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Backout by csabou@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/55313d9fd453
Backed out changeset 302ce3cdb98f for turning bug 1480702 into permafail. a=backout
Backout by csabou@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/8546719c58dc
Backed out changeset 419fd4edef4f for turning Bug 1480702 into permafail. a=backout
Backed out for turning Bug 1480702 into permafail. I don't know how these two are related but looking at the below retriggers it shows clearly this is where it started. 

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-searchStr=Android%204.3%20API16%2B%20debug%20Mochitests%20test-android-em-4.3-arm7-api-16%2Fdebug-mochitest-36%20M(36)&fromchange=597222dce884518ce020cd7a1552d0b571a158de&tochange=fd9dd6df3ae7acc647af581a8e0db4e6d43aa6b9&selectedJob=193959051

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=193959051&repo=autoland&lineNumber=1556

Backout links: 
https://hg.mozilla.org/mozilla-central/rev/55313d9fd453e37f3a34b9f9c9b714d4ccbb320d
https://hg.mozilla.org/mozilla-central/rev/8546719c58dc2310bdafb81fd64a6295c59cd10e


[task 2018-08-14T21:27:10.656Z] 21:27:10     INFO -  131 INFO TEST-PASS | dom/tests/mochitest/fetch/test_request.html | NestedWorker: true: Used Request cannot be passed to new Request
[task 2018-08-14T21:27:10.656Z] 21:27:10     INFO -  Buffered messages finished
[task 2018-08-14T21:27:10.657Z] 21:27:10     INFO -  132 INFO TEST-UNEXPECTED-FAIL | dom/tests/mochitest/fetch/test_request.html | ServiceWorker: worker failed to import test_request.js; error: Failed to load worker script at test_request.js (nsresult = 0x8053000b)
[task 2018-08-14T21:27:10.657Z] 21:27:10     INFO -      onMessage@dom/tests/mochitest/fetch/fetch_test_framework.js:93:13
[task 2018-08-14T21:27:10.657Z] 21:27:10     INFO -  133 INFO TEST-OK | dom/tests/mochitest/fetch/test_request.html | took 34412ms
Status: RESOLVED → REOPENED
Flags: needinfo?(masayuki)
Resolution: FIXED → ---
Target Milestone: mozilla63 → ---
Hmm, if so, it's really odd since my patches changed HTMLEditor which is created only when a document is in designMode or has one or more elements which have contenteditable attribute. Those files do not create HTMLEditor instance:
https://searchfox.org/mozilla-central/source/dom/tests/mochitest/fetch/test_request.html
https://searchfox.org/mozilla-central/source/dom/tests/mochitest/fetch/fetch_test_framework.js
https://searchfox.org/mozilla-central/source/dom/tests/mochitest/fetch/message_receiver.html
Flags: needinfo?(masayuki)
Oh, and according to the treehearder, adding the new automated test caused the failure???
Yeah, I'll reland them with disabling the new test only on debug Android.
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/e6f93da48017
part 0: Add automated tests for nsIHTMLEditor.selectElement() r=m_kato
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/c0c40b74e2b9
part 1: Create HTMLEditor::SelectContentInternal() for internal use of HTMLEditor::SelectElement() r=m_kato
https://hg.mozilla.org/mozilla-central/rev/e6f93da48017
https://hg.mozilla.org/mozilla-central/rev/c0c40b74e2b9
Status: REOPENED → RESOLVED
Closed: Last yearLast year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.