1482036 - Animation progress bar - playing past scroll bar

Status: VERIFIED FIXED

(DevTools :: Inspector: Animations, defect, P3)

Description

[Cristian Fogel [:cfogel]]

Attachment: devT_styleEditor_animTimelineBarNotStopOnScrollBar.gif

[Affected versions]:
- 63.0a1 (2018-08-09), 62.0b14, 61.0.1, 60.1.0esr, 45.3.0ESR

[Affected platforms]:
- win10x64, macOS10.9, Ubuntu 16.04LTS

[Steps to reproduce]:
1. Launch Firefox;
2. Open DevTools - Inspector - Animations Tab;
3. Type "anim" in the Search/Adress bar;
4. Press Enter on the Keyboard;
5. Observe the progress bar for the animations.

[Expected result]:
- The animation progress bar is contained by the section

[Actual result]:
- The progress bar stops at the browser edge, not at the scroll bar for animations;

[Regression range]:
- between ffx_54.0b8 (15-May-2017 23:05) and ffx_55 releases

[Additional notes]:
- attached screen recording with the issue;
- 52.8.0esr, 52.0.2, 54.0b2 are not affected

Comment 1

[Daisuke Akatsuka (:daisuke)]

Thank you for the reporting Cristi.
Do you mean that the problem is that the scrubber is over the scroll bar?
The scrubber will not stop since there is at least one animation whose iteration count is infinity.

Comment 2

[Cristian Fogel [:cfogel]]

Yes. But it should stop being visible when it reaches the scrollbar (or not go over it).

Comment 3

[Daisuke Akatsuka (:daisuke)]

Okay, thanks, I understood!

Comment 4

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1482036: Hold the position of indicator bar in percentage. r=gl

Comment 5

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 9003712 [details]
Bug 1482036: Hold the position of indicator bar in percentage. r=gl

Gabriel [:gl] (ΦωΦ) has approved the revision.

Comment 6

[Daisuke Akatsuka (:daisuke)]

I'll push if the try was green.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0bacdc1bea67f63d3b824c4e2d2eb15a5f6845f1

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f4f34fa31c24
Hold the position of indicator bar in percentage. r=gl

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f4f34fa31c24

Comment 9

[Cristian Fogel [:cfogel]]

Verified on 63.0a1 (2018-08-28) over Windows 10x64, MacOS 10.12, Ubuntu 16.04LTS.