1482077 - 6.46% tsvg_static (linux64-qr) regression on push 62e129cc3495 (Tue Aug 7 2018)

Status: RESOLVED WONTFIX

(Core :: Graphics: WebRender, defect)

Description

[Ionuț Goldan [:igoldan]]

Talos has detected a Firefox performance regression from push:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=f3022e524fc720ecb71b8b3dcda3dfa1ce6bba2a&tochange=62e129cc34958bdfa55e8254b9a257737258686a

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

  6%  tsvg_static linux64-qr opt e10s stylo     71.56 -> 76.18

Improvements:

 19%  tsvgx windows10-64-qr opt e10s stylo     447.78 -> 363.17
 18%  tsvgx linux64-qr opt e10s stylo          414.06 -> 339.20


You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=14818

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the Talos jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://wiki.mozilla.org/Buildbot/Talos/Tests

For information on reproducing and debugging the regression, either on try or locally, see: https://wiki.mozilla.org/Buildbot/Talos/Running

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Our wiki page outlines the common responses and expectations: https://wiki.mozilla.org/Buildbot/Talos/RegressionBugsHandling

Comment 1

[Ionuț Goldan [:igoldan]]

And here are the Gecko profiles for tsvg_static on Linux 64 QR:

before: https://perf-html.io/from-url/https%3A%2F%2Fqueue.taskcluster.net%2Fv1%2Ftask%2FQaBzgiumRQaBgN7J3j6eZw%2Fruns%2F0%2Fartifacts%2Fpublic%2Ftest_info%2Fprofile_tsvg_static.zip

after: https://perf-html.io/from-url/https%3A%2F%2Fqueue.taskcluster.net%2Fv1%2Ftask%2FJ1pOyaC1TQ-nImUDFJDsKQ%2Fruns%2F0%2Fartifacts%2Fpublic%2Ftest_info%2Fprofile_tsvg_static.zip

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Introduced between WR 81005df9ab0c3ae8393adedd879f478dd22bfac3 and WR c939a61b83bcc9dc10742977704793e9a85b3858.

*   c939a61b Auto merge of #2947 - kvark:near-split, r=gw3583
|\
| * d3314021 New near plane splitting reftest
| * 25b1aecd Use frustum clipping for bounding boxes and splitting
* |   cd50308f Auto merge of #2950 - kvark:tex-upload, r=gw3583
|\ \
| |/
|/|
| * b48e32cd Fix texture upload size and track it
* 95640724 Auto merge of #2948 - nical:blob-dirty-rect, r=kvark
* 2f8a542c Evict rasterized blobs on memory pressure events.
* 783d0aed Only paint the dirty rects of non-tiled blobs.

But anyway the regression is small compared to the wins so we should keep the change.