Closed
Bug 1482095
Opened 6 years ago
Closed 6 years ago
Update encoding_rs to 0.8.6
Categories
(Core :: Internationalization, enhancement, P3)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: hsivonen, Assigned: hsivonen)
References
Details
Attachments
(1 file, 1 obsolete file)
|
38.92 KB,
patch
|
emk
:
review+
|
Details | Diff | Splinter Review |
0.8.5 makes some claim about debug-mode assertions made in the patch for bug 1402247 actually true and provides the conversion entry points that enable fixing bug 1482093.
|
Assignee | |
Comment 1•6 years ago
|
||
emk, do you have a Phabricator account? I failed to request review on Phabricator.
Attachment #8998824 -
Flags: review?(VYV03354)
|
|
Assignee | |
Comment 2•6 years ago
|
||
Comment on attachment 8998824 [details] [diff] [review] Update to 0.8.5 Hmm. Asserting may not be feasible.
Attachment #8998824 -
Flags: review?(VYV03354)
|
|
Assignee | |
Comment 3•6 years ago
|
||
0.8.6 drops the assertion from the UTF-16 to Latin1 case to buy time to migrate legacy callers in m-c.
Summary: Update encoding_rs to 0.8.5 → Update encoding_rs to 0.8.6
|
|
Assignee | |
Comment 4•6 years ago
|
||
Attachment #8998824 -
Attachment is obsolete: true
Attachment #8999532 -
Flags: review?(VYV03354)
|
||
Updated•6 years ago
|
Priority: -- → P3
|
||
Updated•6 years ago
|
Attachment #8999532 -
Flags: review?(VYV03354) → review+
Pushed by hsivonen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/46224f5a8a8c Update encoding_rs to 0.8.6. r=emk.
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/46224f5a8a8c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•