1482105 - Constant notification ringing when updating Nightly

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Download Manager, defect)

Description

[Sorina Florean [:sflorean]]

Devices:
Samsung Galaxy Note8 (Android 8.0.0)
Build: Nightly 63.0a1 (2018-08-08);

Steps to reproduce:
1. Go to settings -> Mozilla Nightly -> About Nightly 
2. Tap on check for updates.

Expected result:
A notification is displayed that the download has started.

Actual result:
The phone keeps ringing as the download goes on.


Notes:
Not reproducing: Motorola Nexus 6 (Android 7.1.1), Sony Xperia Z2(Android 6.0.1)

Comment 1

[Sorina Florean [:sflorean]]

Note: not reproducible when trying to update Nightly from Google Play.

Comment 2

[miralobontiu]

Hi,

Ran a regression using OnePlus 5T (Android 8.0).

Regression-window:
First known bad build: 2018-07-17
Last known good build: 2018-07-16

Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2ed1506d1dc7db3d70a3feed95f1456bce05bbee&tochange=547144f5596c1a146b208d68d93950a6313080ca

Comment 3

[Jan Henning [:JanH]]

Adding that particular notification channel should be guarded by AppConstants.MOZ_UPDATER.

Comment 4

[Jan Henning [:JanH]]

Attachment: Bug 1482105 - Use dedicated notification channel for the built-in updater. r?jchen

To avoid cluttering our notification settings on builds not using the built-in
updater, we only add that channel when required.
Passing a null channelId to the system NotificationManager, which can then
happen if someone attempts to use the UPDATER channel anyway, even though
MOZ_UPDATER is false, is safe. It just means that the NotificationManager will
return the system's default channel, which will silently swallow any
notifications posted to it from apps targeting Android O or above.

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 9004973 [details]
Bug 1482105 - Use dedicated notification channel for the built-in updater. r?jchen

Jim Chen [:jchen] [:darchons] has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d407fff0058
Use dedicated notification channel for the built-in updater. r=jchen

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/8d407fff0058

Comment 8

[Ioana Chiorean]

Oana can you have a look at this and verify it on the device we got the regression?

Comment 9

[Oana Horvath [:ohorvath]]

Verified as fixed on Nightly 63 (2018-09-01).

Comment 10

[Bogdan Surd, QA [:bsurd, NI]]

Marking as verified based on Comment 9.