148211 - JS console eval doesn't handle special HTML characters

Status: RESOLVED WORKSFORME

(Toolkit Graveyard :: Error Console, defect)

Description

[[e-mail]]

Using Build ID: 2002053004
Steps to reproduce problem:
1. Open the JS console
2. Type "<" (including the quotes)
3. Press Eval

Expected results: console displays <

Actual results: console displays <

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 3

[Philip Chee]

Problem still exists in the toolkit Error Console.
Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.9.1pre) Gecko/20090614 SeaMonkey/2.0b1pre

Comment 4

[Nochum Sossonko [:Natch]]

Bug 156396 has a fix for this.

Comment 7

[Chris Leary [:cdleary] (not checking bugmail)]

Is there a status update for this bug? (Or perhaps a newer, more relevant bug filed?) I'm guessing the fix from comment 4 wasn't applied, since we just saw a duplicate (bug 616235) where console output was being erroneously interpreted as HTML.

Comment 8

[[e-mail]]

(In reply to comment #7)
> I'm guessing the fix from comment 4 wasn't applied
It no longer works as of bug 290982.

Comment 9

[Chris Leary [:cdleary] (not checking bugmail)]

@neil: That bug was resolved fixed in 2005, but comment 4 was from 2009 -- how did it end up obsoleting the patch? Is there a clear owner for this?

Comment 10

[[e-mail]]

(In reply to comment #9)
> @neil: That bug was resolved fixed in 2005, but comment 4 was from 2009 -- how
> did it end up obsoleting the patch?
Comment 4 refers to a patch in bug 156396 that uses a different approach. The approach in comment 1 no longer works as of 2005.

Comment 11

[Brian Grinstead [:bgrins]]

The Error Console has been removed in favor of the Browser Console (see Bug 1278368), and the component is going to be removed.  If this bug is also relevant in the Browser Console, please reopen and move this into Firefox -> Developer Tools: Console.

Comment 12

[Zack Weinberg (:zwol)]

I am mass-reopening and re-componenting every single one of the Toolkit:Error Console bugs that appear to have been closed without anyone even *glancing* at whether they were relevant to the Browser Console.

If you want to close a whole bunch of old bugs -- FOR ANY REASON -- it is YOUR RESPONSIBILITY to check EVERY SINGLE ONE OF THEM and make sure they are no longer valid.  Do not push that work onto the bug reporters.

(It's okay to close bugs that haven't been touched in years when they don't have enough information for you to figure out whether the problem is still relevant to the current software - the reporter probably isn't coming back to clarify.  But that is the ONLY situation where it is okay.)

(I'm going to have to do this in two steps because of the way the "change several bugs at once" form works.  Apologies for the extra bugspam.)

Comment 13

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Now displays SyntaxError: expected expression, got '&'
I think that qualifies for WFM.